-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxquant: add dotnet-runtime requirement #41221
base: master
Are you sure you want to change the base?
Conversation
When running maxquant I got: ``` .NET Core 3.1 needs to be installed. Please visit https://dotnet.microsoft.com/download/dotnet-core/3.1 and install the SDK x64. ```
Does anyone know how we can get a working download link for maxquant? ping @veitveit @npinter @bgruening Would be even better if the link would be stable... |
For this version I do not have a copy :( For older versions I do https://depot.galaxyproject.org/software/maxquant/ What about upgrading? But this will produce potentially a lot of downstream work. |
You generally need to provide your email address and name to download the software which makes it tricky to provide maxquant as a download link. Making it available through the link above looks like a good solution to me. I had many problems when trying dotnet with Maxquant >=2.0 as there were always conflicts with either .NET core or dotnet itself. Maybe the newest versions solve that now. |
I still asked: cox-labs/CoxLab_Bug_Reporting#32 For the Galaxy tool it seems that dotnet 3.x seems to work https://github.com/galaxyproteomics/tools-galaxyp/pull/700/files#r1210918511 According to MQ docs dotnet >2.7 (linux) and >4.x (win) should work. but error message shows that at least 3.x is needed. So my suggestion would be to try something like .. so probably its the best to bump the recipe here. For the Galaxy tool we can add the additional requirement there |
The Changlog mentions: |
Thanks a lot for taking care of this. And good luck :-)! |
Hi,
Best regards, |
Cool :) So my suggestion would be to mirror the currently available version in bioconda to depot.galaxyproject.org and add a note to the repository that this should be done as well for future versions. I would also add a link to your archive which is an excellent resource. |
@bgruening would a google drive link be fine? or should we create an independent backup? |
Let's use cargo-port. |
OK galaxyproject/cargo-port#172 .. just went for the newest version
|
Could you add 2.3, and 2.4 ? |
When running maxquant I got:
TODO
Describe your pull request here
Please read the guidelines for Bioconda recipes before opening a pull request (PR).
@BiocondaBot please add label
command.@bioconda/core
in a comment.Please use the following BiocondaBot commands:
Everyone has access to the following BiocondaBot commands, which can be given in a comment:
@BiocondaBot please update
@BiocondaBot please add label
please review & merge
label.@BiocondaBot please fetch artifacts
You can use this to test packages locally.
For members of the Bioconda project, the following command is also available:
@BiocondaBot please merge
Someone must approve a PR first!
This reduces CI build time by reusing built artifacts.
Also, the bot watches for comments from non-members that include
@bioconda/<team>
and will automatically re-post them to notify the addressed<team>
.