Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v3 API /ping endpoint with versioning info in the headers #26138

Open
peterbarnett03 opened this issue Mar 14, 2025 · 1 comment
Open
Labels

Comments

@peterbarnett03
Copy link
Contributor

Problem

The v3 API's /ping endpoint has made a change to how versioning info is sent compared to v1 and v2, making those who have specific ways of parsing the endpoints adjust their process, which is unneeded effort on their end.

Desired Solution

We want to include versioning info in the Headers to make it a bit simpler for those migrating that need to do version comparisons; we'll also keep it in the body as well for continuity with current v3, and therefore we'll be keeping it a 200 instead of a 204.

Current v3 API /ping request response:

% curl -i http://localhost:8181/ping

HTTP/1.1 200 OK
date: Fri, 14 Mar 2025 15:04:40 GMT

{"version":"0.1.0","revision":"42117701c0"}%       

Expected v3 API /ping request response:

% curl -i http://localhost:8181/ping

HTTP/1.1 200 OK
Content-Type: application/json
Transfer-Encoding: chunked
Request-Id: [generated-request-id]
X-Influxdb-Build: Core
X-Influxdb-Version: 0.1.0
X-Request-Id: [generated-request-id]
Date: Fri, 14 Mar 2025 15:04:40 GMT

{"version":"0.1.0","revision":"42117701c0"}
@garylfowler
Copy link

Can we also make sure we differentiate between "Core" and "Enterprise" (seems like that is obvious, but mentioning just in case). Also might make sense to have a LicenseType (Trial or Annual, and in the future PAYG). The reason I ask is we might want to enable/disable features in the UI based on the software (Core vs. Enterprise) and possibly license type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants