Update build to avoid git appending -dirty #26147
Assignees
Labels
Comments
jdstrand
added a commit
that referenced
this issue
Mar 16, 2025
We need to both add and remove keys from rustflags, but modifying .cargo/config.toml in place causes the version string to append -dirty. Use ci-support that sets CARGO_CONFIG_TOML, then call it to put ./.cargo/config into place (a historic name that is preferred over ./.cargo/config.toml if it exists) and git ignore ./.cargo/config. References: - #26147 - https://doc.rust-lang.org/cargo/reference/config.html?highlight=rustflags#hierarchical-structure
jdstrand
added a commit
that referenced
this issue
Mar 16, 2025
We need to both add and remove keys from rustflags, but modifying .cargo/config.toml in place causes the version string to have -dirty appended to it. Use ci-support that instead creates ./.cargo/config (a historic filename that is preferred over ./.cargo/config.toml if it exists) and then git ignore ./.cargo/config. References: - #26147 - https://doc.rust-lang.org/cargo/reference/config.html?highlight=rustflags#hierarchical-structure
jdstrand
added a commit
that referenced
this issue
Mar 16, 2025
We need to both add and remove keys from rustflags, but modifying .cargo/config.toml in place causes the version string to have -dirty appended to it. Use ci-support that instead creates ./.cargo/config (a historic filename that is preferred over ./.cargo/config.toml if it exists) and then git ignore ./.cargo/config. References: - #26147 - https://doc.rust-lang.org/cargo/reference/config.html?highlight=rustflags#hierarchical-structure
jdstrand
added a commit
that referenced
this issue
Mar 16, 2025
We need to both add and remove keys from rustflags, but modifying .cargo/config.toml in place causes the version string to have -dirty appended to it. Use ci-support that instead creates ./.cargo/config (a historic filename that is preferred over ./.cargo/config.toml if it exists) and then git ignore ./.cargo/config. References: - #26147 - https://doc.rust-lang.org/cargo/reference/config.html?highlight=rustflags#hierarchical-structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I introduced this with the Linux builds by adjusting
target-envto change.cargo/config.tomlto add and remove rustflags. I can do this a different way so not cause -dirty to be appended.The text was updated successfully, but these errors were encountered: