Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store triggers by DbId and TriggerId instead of name #26153

Open
hiltontj opened this issue Mar 17, 2025 · 0 comments
Open

Store triggers by DbId and TriggerId instead of name #26153

hiltontj opened this issue Mar 17, 2025 · 0 comments

Comments

@hiltontj
Copy link
Contributor

Problem

The ProcessingEngineManagerImpl stores triggers maps that use String names for databases and triggers:

#[derive(Debug, Default)]
struct PluginChannels {
/// Map of database to wal trigger name to handler
wal_triggers: HashMap<String, HashMap<String, mpsc::Sender<WalEvent>>>,
/// Map of database to schedule trigger name to handler
schedule_triggers: HashMap<String, HashMap<String, mpsc::Sender<ScheduleEvent>>>,
/// Map of request path to the request trigger handler
request_triggers: HashMap<String, mpsc::Sender<RequestEvent>>,
}

Proposed solution

  • Change to using the DbId and TriggerId that identify these resources in the catalog.
  • Methods that start/stop triggers should use these IDs as arguments instead of the names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant