{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":11131631,"defaultBranch":"main","name":"fbthrift","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-07-02T18:15:51.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717426974.0","currentOid":""},"activityList":{"items":[{"before":"c182426479d9cb21f3d9422e79af6afb882fd50d","after":"5252ccb9ee0cff36589b841e069518897419170a","ref":"refs/heads/main","pushedAt":"2024-06-08T16:34:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/e434f25ce9188b0c4de1918ed112fa958344acfe\nhttps://github.com/facebook/fb303/commit/591e85c25b53ed19b530400ceb4d9a4cc10bfba7\nhttps://github.com/facebook/fbthrift/commit/c182426479d9cb21f3d9422e79af6afb882fd50d\nhttps://github.com/facebook/folly/commit/4db31bf3f1557698be440981e5fea8b3d5bb427f\nhttps://github.com/facebook/mvfst/commit/2052e4dca48130352bdf28552252e5d3ae545d2f\nhttps://github.com/facebook/proxygen/commit/e52c2eaf99f5aac4ab4813d3e23e780e2558aafd\nhttps://github.com/facebook/wangle/commit/8e9bf37a9745db1ee7e8661d413ce81d101b9cee\nhttps://github.com/facebookexperimental/edencommon/commit/4d85d9e219584a0bbec4fefb438e73ef89fd8ecb\nhttps://github.com/facebookexperimental/rust-shed/commit/1148793aa8f6800da1b5b971af9f34f0f12b5405\nhttps://github.com/facebookincubator/fizz/commit/30638bdfea4fd0760dab69bc2807617dbd1cf68b\n\nReviewed By: ajb85\n\nfbshipit-source-id: ecdf46a48c148e165c7d5c96a54eda4bccc742c6","shortMessageHtmlLink":"Updating submodules"}},{"before":"39e703e54156451a354bf8b92f485da7765da03a","after":"c182426479d9cb21f3d9422e79af6afb882fd50d","ref":"refs/heads/main","pushedAt":"2024-06-08T01:33:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use only absolute paths in generated code, not imports\n\nSummary: Having an import far apart from the uses of the import makes it tricky to maintain the property that something is imported if-and-only-if it is used. Using absolute paths in generated code avoids this, and is a common pattern in Rust macro-generated code too.\n\nReviewed By: capickett\n\nDifferential Revision: D58304632\n\nfbshipit-source-id: 47d5da19155b76b1d12cba7411afb40e4723ddd2","shortMessageHtmlLink":"Use only absolute paths in generated code, not imports"}},{"before":"d10ef98e1065fd6a2e94b837677316b501ba989c","after":"39e703e54156451a354bf8b92f485da7765da03a","ref":"refs/heads/main","pushedAt":"2024-06-08T00:32:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add function to recursively check whether struct uses op encode\n\nReviewed By: iahs\n\nDifferential Revision: D58298542\n\nfbshipit-source-id: bff10a25abce6bbe253ecc973a45c2ca363c4d8e","shortMessageHtmlLink":"add function to recursively check whether struct uses op encode"}},{"before":"1c4b9c78db7f24d8e5fccfc739985bdf43255158","after":"d10ef98e1065fd6a2e94b837677316b501ba989c","ref":"refs/heads/main","pushedAt":"2024-06-07T23:09:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Extend typeinfo test for mutable types\n\nSummary: Extend the typeinfo test for `MutableListTypeInfo` and `MutableSetTypeInfo`\n\nReviewed By: ahilger\n\nDifferential Revision: D58301474\n\nfbshipit-source-id: 22fc71a8bbce44acc8f6d28344342654d2c9eb53","shortMessageHtmlLink":"Extend typeinfo test for mutable types"}},{"before":"aff878de8a072a079c9ed89da061d5fbbcac96da","after":"1c4b9c78db7f24d8e5fccfc739985bdf43255158","ref":"refs/heads/main","pushedAt":"2024-06-07T22:24:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Allow disabling ResourcePool join executor on ::stop() behavior\n\nSummary:\nUsers are reporting log spam resulting from D57887250 due to the use of custom, non-owning executor wrappers in the auxiliary ResourcePools.\n\nThis diff adds the ability to tell a ResourcePool that it should not attempt to join the executor on exit. This is useful for cases where multiple ResourcePools internally use the same executor.\n\nShould the ResourcePool be configured to join the executor on stop, the original WARNING message has also been updated to include the name of the offending ResourcePool.\n\nDifferential Revision: D58291989\n\nfbshipit-source-id: 0d04f97f2b7c7ceaa6741354acce6e2b3f8b0956","shortMessageHtmlLink":"Allow disabling ResourcePool join executor on ::stop() behavior"}},{"before":"6d53d38026d61ae294a3defef618519c87caebea","after":"aff878de8a072a079c9ed89da061d5fbbcac96da","ref":"refs/heads/main","pushedAt":"2024-06-07T20:16:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Edit intro.md using inpage editor\n\nSummary:\nThis diff has been automatically generated by the inpage editor.\n\nNOTE: If you want to update this diff, go via the preview link inside the static docs section below.\nEnsure you are editing the same page that was used to create this diff.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D58195513\n\nfbshipit-source-id: f2fcca9b8a12831f480514665a1b55ab48e39b74","shortMessageHtmlLink":"Edit intro.md using inpage editor"}},{"before":"d0c30c34f498c729e14b91e20483c49650c7e84c","after":"6d53d38026d61ae294a3defef618519c87caebea","ref":"refs/heads/main","pushedAt":"2024-06-07T18:55:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Refactor cpp std imports mustache\n\nSummary: Small diff to factor out common `cimport`s of std cpp types. Used in next diff that introduces a `container_converter` cython module that requires `cimport`ing the same cpp types here.\n\nReviewed By: yoney\n\nDifferential Revision: D58219727\n\nfbshipit-source-id: 972670f481636c8f8fff61152b1813a8f9de516b","shortMessageHtmlLink":"Refactor cpp std imports mustache"}},{"before":"e2aca17d327f73de2e1645171520903abd5f5a5e","after":"d0c30c34f498c729e14b91e20483c49650c7e84c","ref":"refs/heads/main","pushedAt":"2024-06-07T18:48:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"make generated containers final to reduce binary size\n\nSummary:\nCython generates all kinds of junk to accommodate python classes inheriting from these. However, any such use cases are a blocker to moving away from thrift-py3, so let's ban.\n\nBuild size impacc:\nef1cc925f2591dd6b2ca41f407333ec4318a23c0 (fbcode/warm): 3972833280 (3788 MB)\nThis diff: 3973480448 (3789 MB)\n\nReviewed By: yoney\n\nDifferential Revision: D58269017\n\nfbshipit-source-id: 02403a3f7d87e041f6a75794f703cdfc769980d3","shortMessageHtmlLink":"make generated containers final to reduce binary size"}},{"before":"c552658aff5ce8d184d26ce3212f78a3c793463d","after":"e2aca17d327f73de2e1645171520903abd5f5a5e","ref":"refs/heads/main","pushedAt":"2024-06-07T18:22:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Getdeps for hsthrift\n\nSummary:\nX-link: https://github.com/facebookincubator/hsthrift/pull/134\n\nX-link: https://github.com/facebookincubator/zstrong/pull/873\n\nBuilds and tests hsthrift with the fbthrift dependency.\n\nReviewed By: phlalx\n\nDifferential Revision: D58242707\n\nfbshipit-source-id: 3cebb06e6659615a0077859f64a58fef3b3c5067","shortMessageHtmlLink":"Getdeps for hsthrift"}},{"before":"e71462eb70a9369e9499be3bc97d402d82ed62dc","after":"c552658aff5ce8d184d26ce3212f78a3c793463d","ref":"refs/heads/main","pushedAt":"2024-06-07T18:19:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Pass type-erased request arguments to ServiceInterceptor::onRequest\n\nSummary:\nThis diff exposes incoming request arguments from an RPC to `ServiceInterceptor::onRequest` in a type-safe but type-erased manner.\n\nIt achieves this by creating a vtable (at compile time) mapping compile-time constructs (`std::get<Index>(std::tuple)` and `std::tuple_element_t<Index, std::tuple>`) to runtime constructs (see `getTypeErased` which returns `std::get<Index>` as `const void*` and `std::tuple_element_t` as `std::type_info`).\n\nThe runtime cost is minimized as much as possible — additional compile time work is required to create the dynamic jump table for the machinery described above, and dynamic type-checking only happens upon access. When they are not used, the additional cost is setting some pointers (one per argument) in `ArgsState::asTupleOfRefs` in generated code (see `process_and_return.mustache`).\n\nReviewed By: sethdelliott\n\nDifferential Revision: D58217405\n\nfbshipit-source-id: fa9dd9d8cd346b2047073b9c3bb395d7062681ba","shortMessageHtmlLink":"Pass type-erased request arguments to ServiceInterceptor::onRequest"}},{"before":"165601b51a7bf686cfc9427d62ae86f03f476fb4","after":"e71462eb70a9369e9499be3bc97d402d82ed62dc","ref":"refs/heads/main","pushedAt":"2024-06-07T16:37:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/3883631c5869605c73f3e4ecc20efabcde6e9cb4\nhttps://github.com/facebook/fb303/commit/24b2b4d3896db696cb7a293d5318a75b4b1dca47\nhttps://github.com/facebook/fbthrift/commit/165601b51a7bf686cfc9427d62ae86f03f476fb4\nhttps://github.com/facebook/folly/commit/a7e3b7a242383e2217a1efd1fdf51ccc37f0d1a8\nhttps://github.com/facebook/mvfst/commit/3ff5f31c262869a70a210fc46d4871e05dd79e1a\nhttps://github.com/facebook/proxygen/commit/ca9a56a5a1239a24fddd4ee8e2cbfe1dd01b7201\nhttps://github.com/facebook/wangle/commit/076bdcb51d8789321ea0510124c5dcef8a676d21\nhttps://github.com/facebookexperimental/edencommon/commit/e1586778cd0622d0ab51cd69416d5dc5a93a12b4\nhttps://github.com/facebookexperimental/rust-shed/commit/f87aced8dfcb2fffb6702f279428f771f4098eea\nhttps://github.com/facebookincubator/fizz/commit/7a1b1cbfa21f9713368aa5204d13e65202919318\n\nReviewed By: ajb85\n\nfbshipit-source-id: 82ed642f739a391ade0c74abff82fd9d9cebe85c","shortMessageHtmlLink":"Updating submodules"}},{"before":"7db5a066e9d011c19e1df8b3e07aa37e3b7e9c99","after":"165601b51a7bf686cfc9427d62ae86f03f476fb4","ref":"refs/heads/main","pushedAt":"2024-06-07T08:00:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fixing shadowing in AsyncProcessor.h\n\nReviewed By: Filip-F\n\nDifferential Revision: D58267427\n\nfbshipit-source-id: be062b1b68585528f3fff4a554b4dcaa54fc50b0","shortMessageHtmlLink":"Fixing shadowing in AsyncProcessor.h"}},{"before":"a0aa1db6e10ea978810200b833608a7ea2545efe","after":"7db5a066e9d011c19e1df8b3e07aa37e3b7e9c99","ref":"refs/heads/main","pushedAt":"2024-06-06T23:15:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"TypeErasedRef\n\nSummary: The doc block explains it well. It's essentially a `void*` with an accompanying `std::type_info` which provides some basic runtime type safety.\n\nReviewed By: sethdelliott\n\nDifferential Revision: D58217404\n\nfbshipit-source-id: 609414a0e21fe59c514d8d1340a6bc5c95a34a89","shortMessageHtmlLink":"TypeErasedRef"}},{"before":"b6609b654788db1a0707a3c58a01004ff027fa61","after":"a0aa1db6e10ea978810200b833608a7ea2545efe","ref":"refs/heads/main","pushedAt":"2024-06-06T21:21:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Deshim FunctionScheduler in thrift\n\nSummary:\nThe following rules were deshimmed:\n```\n//folly/experimental:function_scheduler -> //folly/executors:function_scheduler\n```\n\nThe following headers were deshimmed:\n```\nfolly/experimental/FunctionScheduler.h -> folly/executors/FunctionScheduler.h\n```\n\nThis is a codemod. It was automatically generated and will be landed once it is approved and tests are passing in sandcastle.\nYou have been added as a reviewer by Sentinel or Butterfly.\n\np:ad_defsx.thrift\n\nReviewed By: yfeldblum\n\nDifferential Revision: D58155075\n\nfbshipit-source-id: ab249347e5d464ab41b5acf410dbc580945b9693","shortMessageHtmlLink":"Deshim FunctionScheduler in thrift"}},{"before":"999bafbca0f9f21f76414e732dcf933bc673ea3d","after":"b6609b654788db1a0707a3c58a01004ff027fa61","ref":"refs/heads/main","pushedAt":"2024-06-06T20:24:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Edit compatibility.md using inpage editor\n\nSummary:\n1. Modified wire compatibility.\n2. IMHO it's misleading to say changing default value doesn't require code change. Some code might rely on the old default value which we don't know.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D58245482\n\nfbshipit-source-id: 98efd35c1bb4607ca0c33d1c5c18d1f73e4dc3c9","shortMessageHtmlLink":"Edit compatibility.md using inpage editor"}},{"before":"855a0eb38333f9cc9640ae20d720f0f7334f5cd8","after":"999bafbca0f9f21f76414e732dcf933bc673ea3d","ref":"refs/heads/main","pushedAt":"2024-06-06T17:57:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve the error message.\n\nSummary: Improve the error message to make it clear.\n\nReviewed By: thedavekwon\n\nDifferential Revision: D58151545\n\nfbshipit-source-id: 7466118e56b82e4c3f5cc1c48dcfeb18af29c962","shortMessageHtmlLink":"Improve the error message."}},{"before":"18cbe19de8654efd1a1f392e15774403f6d19d6e","after":"855a0eb38333f9cc9640ae20d720f0f7334f5cd8","ref":"refs/heads/main","pushedAt":"2024-06-06T17:41:55.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Make TypeInfo classes final\n\nSummary: Make the TypeInfo classes final so that they cannot be extended.\n\nReviewed By: aristidisp\n\nDifferential Revision: D58233726\n\nfbshipit-source-id: b869fd22fb713925793ab5bc9b54700626d061bd","shortMessageHtmlLink":"Make TypeInfo classes final"}},{"before":"39b7ad2836467a0c408e785ea259684a5788007b","after":"18cbe19de8654efd1a1f392e15774403f6d19d6e","ref":"refs/heads/main","pushedAt":"2024-06-06T17:29:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unneeded string conversions of primitives\n\nSummary:\nRationale: just tidier code at all these call sites. I was not able to measure any performance difference from this change. The same integer-to-string conversion happens either way, it's just a matter of whether it happens with a `std::to_string` or `fmt::format(\"{}\", …)` at the time of construction of the `mstch::node`, vs a `fmt::format_to` during rendering.\n\nhttps://www.internalfb.com/code/fbsource/[0e2272aad4fb00d28440c77135230f703c7fbf77][outline]/fbcode/thrift/compiler/detail/mustache/visitor/render_node.h?lines=42%2C49-51%2C82\n\nEither way no memory allocation is happening because the longest value of `int` is only 11 characters which is less than the inline capacity of `std::string`.\n\nThe most likely reason that a performance regression would occur is if there is some node which is rendered disproportionately many times. Before, the int-to-string formatting would have been done exactly once, whereas now it'll happen as many times as the node is rendered. To the extent that this happens in any of our templates, formatting an integer to string is cheap enough that the difference is apparently negligible in practice.\n\nThis change does affect the behavior of `is_node_empty`, which is invoked when a template does `{{#method}}...{{/method}}`. A node created using `std::to_string(0)` would be considered truthy whereas directly using integer `0` is falsey.\n\nhttps://www.internalfb.com/code/fbsource/[0e2272aad4fb00d28440c77135230f703c7fbf77][outline]/fbcode/thrift/compiler/detail/mustache/visitor/is_node_empty.h?lines=37%2C46%2C52%2C55\n\nHowever, this doesn't impact the behavior of any existing template because there would have been no reason for any of them to be doing a `{{#...}}` on a node that holds a stringified integer, as such a node would never have been falsey before this diff.\n\nReviewed By: diliop\n\nDifferential Revision: D57946615\n\nfbshipit-source-id: 5a3d04bc63418018347afb344b6b649b83bf9072","shortMessageHtmlLink":"Remove unneeded string conversions of primitives"}},{"before":"ea0eca5328cbbbe178356aad0bfe3e5e3d2553db","after":"39b7ad2836467a0c408e785ea259684a5788007b","ref":"refs/heads/main","pushedAt":"2024-06-06T17:23:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add a checked construction from size_t\n\nSummary:\nPreviously, `mstch::node` was constructible from `int`, but not from `size_t`:\n\n```lang=text,counterexample\nbuck-out/v2/gen/fbcode/72ae41e9eca77500/thrift/compiler/generate/__generate__/buck-headers/thrift/compiler/generate/mstch_objects.h:481:12: error: no viable conversion from returned value of type 'std::vector::size_type' (aka 'unsigned long') to function return type 'mstch::node'\n    return program_->intern_list().size();\n           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\nbuck-out/v2/gen/fbcode/72ae41e9eca77500/thrift/compiler/detail/mustache/__mustache__/buck-headers/thrift/compiler/detail/mustache/mstch.h:134:8: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'std::vector::size_type' (aka 'unsigned long') to 'const apache::thrift::mstch::node &' for 1st argument\nstruct node : internal::node_base<node> {\n       ^\nbuck-out/v2/gen/fbcode/72ae41e9eca77500/thrift/compiler/detail/mustache/__mustache__/buck-headers/thrift/compiler/detail/mustache/mstch.h:134:8: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'std::vector::size_type' (aka 'unsigned long') to 'apache::thrift::mstch::node &&' for 1st argument\nbuck-out/v2/gen/fbcode/72ae41e9eca77500/thrift/compiler/detail/mustache/__mustache__/buck-headers/thrift/compiler/detail/mustache/mstch.h:138:18: note: candidate constructor not viable: no known conversion from 'std::vector::size_type' (aka 'unsigned long') to 'std::string_view' (aka 'basic_string_view<char>') for 1st argument\n  /* implicit */ node(std::string_view sv) : base(std::string(sv)) {}\n                 ^\nfbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/variant:1399:2: note: candidate template ignored: requirement '18446744073709551615UL < sizeof...(_Types)' was not satisfied [with _Tp = unsigned long, $1 = void, $2 = void]\n        variant(_Tp&& __t)\n        ^\nnote: remaining 4 candidates omitted; pass -fshow-overloads=all to show them\n```\n\nBut nodes whose value is determined by `.size()` of some collection is a common use case, so 2 workarounds are in use:\n\n- a truncating cast from `size_t` to `int`:\n\nhttps://www.internalfb.com/code/fbsource/[d9ef90475b5bb75d10745d9bf8dfb7f0e28e0e91]/fbcode/thrift/compiler/generate/t_mstch_java_generator.cc?lines=1104-1106\n\n- create a `mstch::node` holding a `std::string`, instead of `int`:\n\nhttps://www.internalfb.com/code/fbsource/[d9ef90475b5bb75d10745d9bf8dfb7f0e28e0e91]/fbcode/thrift/compiler/generate/t_mstch_cpp2_generator.cc?lines=1204\n\nThis diff adds a new `mstch::node` constructor taking `size_t` and producing a node containing `int`, or an exception on overflow.\n\nI don't expect that we will ever observe this exception in practice, but if we do, it might be reasonable to adjust this constructor to use `std::to_string`, either unconditionally or only in the case of `int` overflow.\n\nReviewed By: iahs\n\nDifferential Revision: D57946616\n\nfbshipit-source-id: c4a1ff1d993f92472ac555a4d6468fa5fff6f335","shortMessageHtmlLink":"Add a checked construction from size_t"}},{"before":"0ac2d689243be496a6b283b75126a14a6503236e","after":"ea0eca5328cbbbe178356aad0bfe3e5e3d2553db","ref":"refs/heads/main","pushedAt":"2024-06-06T16:36:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/3803afe4209fab712543a0779d7aeef168a11b0c\nhttps://github.com/facebook/fb303/commit/5a4c37962d38b9a8b8a66eb60e13dbe5ea4d2269\nhttps://github.com/facebook/fbthrift/commit/0ac2d689243be496a6b283b75126a14a6503236e\nhttps://github.com/facebook/folly/commit/fcdc924205c66ff86a78e2b31e2f866288a141a6\nhttps://github.com/facebook/mvfst/commit/32db35ff4f689c971f02b739e3eff1e9835a4aae\nhttps://github.com/facebook/proxygen/commit/42696ea895dc45191974a489cdec97ec5e8348ff\nhttps://github.com/facebook/wangle/commit/1cf03132c4346926ec92d3f2845b18d2cbfcb729\nhttps://github.com/facebookexperimental/edencommon/commit/c039824a2d8b9f362b1e99f6d3e2544b33e9bb20\nhttps://github.com/facebookexperimental/rust-shed/commit/ecc3a6c1fa20245896f303fb3819675ac616a764\nhttps://github.com/facebookincubator/fizz/commit/67d18908b2316d3995f1c8fb8bc7c65acbdcdeb5\n\nReviewed By: ajb85\n\nfbshipit-source-id: d73dc459aceef41b760ccdf9c09efdc879d022b0","shortMessageHtmlLink":"Updating submodules"}},{"before":"073d4612efaad4ef23c136e4ea0574d367c0eff0","after":"0ac2d689243be496a6b283b75126a14a6503236e","ref":"refs/heads/main","pushedAt":"2024-06-06T14:53:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"debug doesn't require build first\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/870\n\nbrainfart\n\nReviewed By: chadaustin\n\nDifferential Revision: D58200715\n\nfbshipit-source-id: ccb02285e672e3e638e6eda92fc0610eb903cb69","shortMessageHtmlLink":"debug doesn't require build first"}},{"before":"0b611e4e877e22f71fbc4b84213a9631f6ae8216","after":"073d4612efaad4ef23c136e4ea0574d367c0eff0","ref":"refs/heads/main","pushedAt":"2024-06-06T11:20:06.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"set keep alives according to java's implemention to avoid SEV\n\nSummary: set keep alives according to java's implemention to avoid SEV, see T182939211 for more context\n\nReviewed By: leoleovich\n\nDifferential Revision: D58191176\n\nfbshipit-source-id: 96c33660692a8906d3d55e5098e2746d0b75eb46","shortMessageHtmlLink":"set keep alives according to java's implemention to avoid SEV"}},{"before":"6da5e8e52ba686b31c72d4c7a24d0f9fddef3bee","after":"0b611e4e877e22f71fbc4b84213a9631f6ae8216","ref":"refs/heads/main","pushedAt":"2024-06-06T10:51:06.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove unused SetTimeout method from socket\n\nSummary: remove unused SetTimeout method from socket\n\nReviewed By: leoleovich\n\nDifferential Revision: D58183627\n\nfbshipit-source-id: 7393efa332f536ff3d04716763b3acd196d4bc94","shortMessageHtmlLink":"remove unused SetTimeout method from socket"}},{"before":"5d757729e3fc49321943e7eb4802c036929fe057","after":"6da5e8e52ba686b31c72d4c7a24d0f9fddef3bee","ref":"refs/heads/main","pushedAt":"2024-06-06T10:21:48.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"remove call to underlying Conn\n\nSummary: remove call to underlying Conn\n\nReviewed By: leoleovich\n\nDifferential Revision: D58141430\n\nfbshipit-source-id: ccfcb5cd445e7e6a716d558249be9afc52f84404","shortMessageHtmlLink":"remove call to underlying Conn"}},{"before":"586e9d5877469d609729a563d67c3509bf0d196d","after":"5d757729e3fc49321943e7eb4802c036929fe057","ref":"refs/heads/main","pushedAt":"2024-06-06T03:40:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix max connection lease\n\nDifferential Revision: D58219323\n\nfbshipit-source-id: acafceae0ffea418991d13406b1a162a1a409ea6","shortMessageHtmlLink":"Fix max connection lease"}},{"before":"47980eda2b3ee10bdfc4d5bf0b2161585445ee3e","after":"586e9d5877469d609729a563d67c3509bf0d196d","ref":"refs/heads/main","pushedAt":"2024-06-06T03:17:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Avoid null members field reference in Protocol Object during serialization\n\nSummary: TSIA\n\nReviewed By: iahs\n\nDifferential Revision: D58214981\n\nfbshipit-source-id: 4cb1cf9fb41b935c2700e99a8d95a69f42bad2e4","shortMessageHtmlLink":"Avoid null members field reference in Protocol Object during serializ…"}},{"before":"a2ffd16173f0fe878353e68b3845f176fa3a304d","after":"47980eda2b3ee10bdfc4d5bf0b2161585445ee3e","ref":"refs/heads/main","pushedAt":"2024-06-06T01:54:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix some capitalization in docs\n\nSummary:\n\"Thrift\" is a proper noun, referring to the name of the language so it should be capitalized. Fix a common class of mistakes noticed in D58210522 via a codemod:\n\n```\ncodemod -d thrift/doc --extension md \" thrift file\" \" Thrift file\"\n```\n\nReviewed By: iahs\n\nDifferential Revision: D58210778\n\nfbshipit-source-id: 9b60c6e4c9018884f943c0309b021dc1b1b9492f","shortMessageHtmlLink":"Fix some capitalization in docs"}},{"before":"1e3df6c01451b71c435e598332ca70c6f8dc95ed","after":"a2ffd16173f0fe878353e68b3845f176fa3a304d","ref":"refs/heads/main","pushedAt":"2024-06-06T01:47:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Memory optimization for wangle acceptors\n\nSummary:\nReintroduction of D57630153 that was reverted with D57921241 due to bug in  one `SharedSSLContextManager::updateSSLConfigAndReloadContexts` implementation.\n\n- Aims to save memory by using shared `ServerSocketConfig` per acceptor.\n\nReviewed By: mingtaoy\n\nDifferential Revision: D57940262\n\nfbshipit-source-id: dcdd86ce70f88686ae180ce069874f15cae24829","shortMessageHtmlLink":"Memory optimization for wangle acceptors"}},{"before":"fa60eee4e34802a1fbf75e639d4a2aba87ddff99","after":"1e3df6c01451b71c435e598332ca70c6f8dc95ed","ref":"refs/heads/main","pushedAt":"2024-06-06T01:02:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rename Patch structs for rust\n\nSummary: Inject the `rust.Name{name = \"{original_name}PatchStructInternalDoNotUse\"}` annotation  into the Patch structs to caution developers against accidental usage.\n\nReviewed By: Mizuchi\n\nDifferential Revision: D58198515\n\nfbshipit-source-id: 363e2f7e5c839fb7d3e1e7b7a6907cf189279295","shortMessageHtmlLink":"Rename Patch structs for rust"}},{"before":"dd099b6ce2db30d6b299a14b8743ed7ec175c558","after":"fa60eee4e34802a1fbf75e639d4a2aba87ddff99","ref":"refs/heads/main","pushedAt":"2024-06-05T23:16:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix protocolSortKeys handling\n\nSummary: Convert the list to a tuple after sorting, since the next loop block expects a tuple.\n\nReviewed By: ahilger\n\nDifferential Revision: D58194383\n\nfbshipit-source-id: 6c6c8ddcfdda1b92fa14284796ac66182f5d7728","shortMessageHtmlLink":"Fix protocolSortKeys handling"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX_8l9gA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/fbthrift"}