{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1181927,"defaultBranch":"master","name":"bitcoin","ownerLogin":"bitcoin","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2010-12-19T15:16:43.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/528860?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1716978741.0","currentOid":""},"activityList":{"items":[{"before":"3ac1465cd9da8d328972a67d4c623a012a276e81","after":"457e1846d2bf6ef9d54b9ba1a330ba8bbff13091","ref":"refs/heads/master","pushedAt":"2024-05-31T14:30:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30204: depends: consolidate dependency docs\n\na27e1ceb9f9c9239af9b0a151c84a57573ea646a depends: consolidate dependency docs (fanquake)\n\nPull request description:\n\n  Adds missing `g++` for macOS. This is needed by Qt:\n  ```bash\n  Configuring qt...\n  Creating qmake...\n  gmake[1]: Entering directory '/bitcoin/depends/work/build/arm64-apple-darwin/qt/5.15.14-4bca24c8f89/qtbase/qmake'\n  gmake[1]: g++: No such file or directory\n  gmake[1]: *** [Makefile:250: main.o] Error 127\n  ```\n\n  `xz-utils` was also missing (but generally already installed), and is needed for the `.tar.xz` tarballs.\n\n  Remove `bsdmainutils`, as this is only needed by the main build system (for tests), and isn't needed to complete a depends build.\n\nACKs for top commit:\n  maflcko:\n    ACK a27e1ceb9f9c9239af9b0a151c84a57573ea646a\n\nTree-SHA512: 720c31d4d4c9b86fda4aace405d528193714dd3e526f38d5b8a83e4b676a433b9c891f01d86d673be9ac848458eda8a89b0981003a42eaa6d97bacc2e914396a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325935400\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30204\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30204/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30204\">#30204</a>: depends: consolidate dependency docs"}},{"before":"62f7f59ff495fbcbfc10c25e97bb0dc032647abf","after":"3ac1465cd9da8d328972a67d4c623a012a276e81","ref":"refs/heads/master","pushedAt":"2024-05-31T14:28:37.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30198: depends: qt 5.15.14 and fix macOS build with Clang 18\n\n0a3631fc352eda849290db940844e5ef723436df depends: fix Qt macOS build with Clang 18 (fanquake)\nb018bd779dd9b2d46c10254a1cf5b819ae8e027c depends: qt 5.15.14 (fanquake)\n\nPull request description:\n\n  Also adds a patch to Qts internal libpng, to fix compilation using Clang 18, when targetting macOS. I'd like to get this patched, so we can continue working on removing `FORCE_USE_SYSTEM_CLANG` (#30201); otherwise builds will be broken using the default Clang (`18`) on the current Ubuntu LTS (`24.04`).\n\n  With this PR, anyone using Ubuntu 24.04 should be able to `apt install clang llvm lld`, and then cross-compile for macOS using:\n  ```bash\n  # clang --version\n  Ubuntu clang version 18.1.3 (1)\n  make -C depends HOST=arm64-apple-darwin FORCE_USE_SYSTEM_CLANG=1\n  ./autogen.sh\n  CONFIG_SITE=/path/to/depends/arm64-apple-darwin/share/config.site ./configure\n  make\n  # file src/qt/bitcoin-qt\n  src/qt/bitcoin-qt: Mach-O 64-bit arm64 executable, flags:<NOUNDEFS|DYLDLINK|TWOLEVEL|WEAK_DEFINES|BINDS_TO_WEAK|PIE|HAS_TLV_DESCRIPTORS>\n  ```\n\nACKs for top commit:\n  TheCharlatan:\n    ACK 0a3631fc352eda849290db940844e5ef723436df\n  theuni:\n    utACK 0a3631fc352eda849290db940844e5ef723436df\n  hebasto:\n    ACK 0a3631fc352eda849290db940844e5ef723436df, a new patch indeed fixes cross-compiling on Ubuntu 24.04 with `FORCE_USE_SYSTEM_CLANG=1`.\n\nTree-SHA512: 711d321b1efbb1aeef802d1d7e72fff8f4e28aa2420d19df9db6f4449fc7d281e1d08ba242ce20122dfe21129e713bd59e7e6ade0b67d7271eea18b39ceb9283","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325395619\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30198\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30198/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30198\">#30198</a>: depends: qt 5.15.14 and fix macOS build with Clang 18"}},{"before":"0a7c650fcd322a46dac7239b421046a61a6a5a20","after":"62f7f59ff495fbcbfc10c25e97bb0dc032647abf","ref":"refs/heads/master","pushedAt":"2024-05-30T14:32:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30199: clang-tidy: Add `bugprone-move-forwarding-reference` check\n\n88cdb5967f093cf96e9184a48c0d9e34cea9d341 clang-tidy: Add `bugprone-move-forwarding-reference` check (Hennadii Stepanov)\n\nPull request description:\n\n  This PR adds [`bugprone-move-forwarding-reference`](https://clang.llvm.org/extra/clang-tidy/checks/bugprone/move-forwarding-reference.html) to the clang-tidy checks.\n\nACKs for top commit:\n  maflcko:\n    utACK 88cdb5967f093cf96e9184a48c0d9e34cea9d341\n\nTree-SHA512: 8366c895085d0656a4491035aa8863c9dca12885c2bdf0392bebc63d6f6f5473ec263594e5fde70a3c211e95d19b9cd98e2c574ced91b4c970cce0edce40bceb","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2325535090\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30199\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30199/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30199\">#30199</a>: clang-tidy: Add <code>bugprone-move-forwarding-reference</code> check"}},{"before":"f61ede574c12f1f8ae67f38f15387586719c856f","after":"0a7c650fcd322a46dac7239b421046a61a6a5a20","ref":"refs/heads/master","pushedAt":"2024-05-30T11:36:13.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30034: ci: add markdown link check job\n\n4b7d9842691046b01f0c08d69f924ddb62ccc4c6 lint: add markdown hyperlink checker (willcl-ark)\n\nPull request description:\n\n  Potential followup to: #30025\n\n  This should prevent us reintroducing broken markdown links.\n\n  It does not test \"online\" (external) links, only those within this repo. Both relative and absolute links are parsed successfully if they resolve.\n\nACKs for top commit:\n  maflcko:\n    re-utACK 4b7d9842691046b01f0c08d69f924ddb62ccc4c6\n  davidgumberg:\n    reACK https://github.com/bitcoin/bitcoin/commit/4b7d9842691046b01f0c08d69f924ddb62ccc4c6\n\nTree-SHA512: 9bc40d700b73499c046bb76157bc139f32ec3850f64ef813bbf7f18f9c01a253abe6a857d6f559890165f2bd26e7742c05d86232cd9b8efb33ff85d735f4f095","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2278290825\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30034\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30034/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30034\">#30034</a>: ci: add markdown link check job"}},{"before":"10164916f712bd3c92f0b3ac329ba2e1209746fe","after":"f61ede574c12f1f8ae67f38f15387586719c856f","ref":"refs/heads/master","pushedAt":"2024-05-30T08:25:47.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30049: build, test, doc: Temporarily remove Android-related stuff\n\n5deb0b024e14c7c63d405c651d1ca323560a1c21 build, test, doc: Temporarily remove Android-related stuff (Hennadii Stepanov)\n\nPull request description:\n\n  Previously, our Android builds were geared towards generating APKs, which relied on Qt. However, after migrating to C++20, compiling for Android became unfeasible due to Qt 5.15's compatibility limitations with NDK only up to r25, which includes an outdated embedded libc++ (see https://github.com/bitcoin/bitcoin/issues/29360).\n\n  All removed stuff will be reinstated after migrating the build system to CMake and upgrading Qt to version 6.x.\n\n  This PR makes possible a clean migration to the CMake-based build system as it removes code, which is not used at this moment.\n\nACKs for top commit:\n  vasild:\n    ACK 5deb0b024e14c7c63d405c651d1ca323560a1c21\n  fanquake:\n    ACK 5deb0b024e14c7c63d405c651d1ca323560a1c21 - given none of this is currently tested/wont compile. Can be revisted in future.\n\nTree-SHA512: 3bc2ccfe881e11cc1d78c27acd6f1d86cfba86821ef3bb5eca2e80d978fdfa13659ec82284dcaadc507e2394524dea91d4b8f81d0030c1cef9708df8be76bf07","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2280498493\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30049\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30049/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30049\">#30049</a>: build, test, doc: Temporarily remove Android-related stuff"}},{"before":"46d3477b5b18384ab022b5e122f6fba64cf4593f","after":"10164916f712bd3c92f0b3ac329ba2e1209746fe","ref":"refs/heads/master","pushedAt":"2024-05-29T09:32:05.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30122: bench: enable wallet creation benchmarks on all platforms\n\n7c8abf3c2001152423da06d25f9f4906611685ea bench: bugfix, properly release wallet before erasing directory (furszy)\n\nPull request description:\n\n  Simple fix for #29816.\n\n  Since the wallet is appended to the global `WalletContext` during\n  creation, merely calling `reset()` on the benchmark shared_pointer\n  is insufficient to destruct the wallet. This no destruction of the\n  wallet object results in keeping the db connection open, which\n  was causes the `fs::remove_all()` failure on Windows.\n\nACKs for top commit:\n  maflcko:\n    utACK 7c8abf3c2001152423da06d25f9f4906611685ea\n  kevkevinpal:\n    utACK [7c8abf3](https://github.com/bitcoin/bitcoin/pull/30122/commits/7c8abf3c2001152423da06d25f9f4906611685ea)\n  hebasto:\n    re-ACK 7c8abf3c2001152423da06d25f9f4906611685ea, I agree with changes since my recent [review](https://github.com/bitcoin/bitcoin/pull/30122#pullrequestreview-2061694682).\n\nTree-SHA512: 279df65bea8f7aa02af0a2efed62dca9bf9b29cb748eb369c602d223e08a8a907dea7b1bffbd3dab91b1656c1d91b18a9a0534bc3f153bd751414b0e6230b3a4","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2300335707\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30122\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30122/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30122\">#30122</a>: bench: enable wallet creation benchmarks on all platforms"}},{"before":"be100cf4c77a3e45750773689e0a396fda39d8a7","after":"46d3477b5b18384ab022b5e122f6fba64cf4593f","ref":"refs/heads/master","pushedAt":"2024-05-29T09:27:16.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30172: fuzz: Handle missing BDBRO errors\n\n9ddf39dd87a3729ceedaa05a207621a02c532536 fuzz: Handle missing BDBRO errors (Ava Chow)\n\nPull request description:\n\n  Adds error messages that were not being handled. Also removes error messages that no longer exist.\n\n  Fixes #30166\n\nACKs for top commit:\n  dergoegge:\n    reACK 9ddf39dd87a3729ceedaa05a207621a02c532536\n  TheCharlatan:\n    ACK 9ddf39dd87a3729ceedaa05a207621a02c532536\n\nTree-SHA512: 2597536a1e5d030653dfcb02fd892f7492f5a091def787f6cbd421b8bca9544847684a498e9458ea99ae7de5a8a6d91532ff904d1e39222d324939d31d2eb3f0","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2315875505\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30172\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30172/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30172\">#30172</a>: fuzz: Handle missing BDBRO errors"}},{"before":"417b6ceceee94b9f291f7f84c4664e5a6bcd3707","after":"be100cf4c77a3e45750773689e0a396fda39d8a7","ref":"refs/heads/master","pushedAt":"2024-05-29T08:42:09.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#21778: build: LLD based macOS toolchain\n\ne8c25e8a35e333e90514945c592557615641553f guix: drop binutils from macOS env (fanquake)\n555fddf646265f7e57a416dc64b171f2c9460e20 guix: use GUIX_LD_WRAPPER_DISABLE_RPATH for all HOSTS (fanquake)\n9ec238d0f3c7b97aec83dbeb4c7a6950c8f5125e guix: remove ZERO_AR_DATE export (fanquake)\nf836f7e9b3e091eb27cdefb624e2a6f2a921fa55 depends: remove cctools & libtapi (fanquake)\n4a0536c5d96688729f8c885060c83cb12d72a8c5 build: switch to using lld for macOS builds (fanquake)\nc6a6b2d6fd4e3a01b095dc98645f819ebabf1931 build: add lld into macOS build environment(s) (fanquake)\n437e908ebd1bf9473ef924de5aec57bdc26de6dd depends: swap cctools-x for llvm-x (fanquake)\nbab287d1bab2c02b5fab3285f2678c15316d31c2 depends: don't use -no_warning_for_no_symbols in macOS qt build (fanquake)\n\nPull request description:\n\n  This switches us to using a [LLD](https://lld.llvm.org/) based toolchain for macOS builds.\n\n  ### Benefits\n  * Less complicated macOS toolchain.\n  * No longer beholden to Apple releasing it's [source](https://opensource.apple.com/source/) for [cctools](https://opensource.apple.com/source/cctools/), [ld64](https://opensource.apple.com/source/ld64/) & [libtapi](https://opensource.apple.com/source/tapi/).\n  * No more reliance on third parties to modify those sources for us. i.e [apple-libtapi](https://github.com/tpoechtrager/apple-libtapi), [cctools-port](https://github.com/tpoechtrager/cctools-port) (cctools + ld64).\n\nACKs for top commit:\n  theuni:\n    Tentative ACK e8c25e8a35e333e90514945c592557615641553f.\n\nTree-SHA512: ec73304e8a2cd4c71041f7863d7d2e4e0408787299fb4fa3745076853156e8f64e4742e16f30d65e3a27f1e9c0d19cdf802248366b72a4fcb4ea821f92bb7a00","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"867374557\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/21778\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/21778/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/21778\">#21778</a>: build: LLD based macOS toolchain"}},{"before":"58956028e4398a33a3bd7ba00aebe03bb589910f","after":"417b6ceceee94b9f291f7f84c4664e5a6bcd3707","ref":"refs/heads/master","pushedAt":"2024-05-29T08:34:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30156: fuzz: More accurate coverage reports\n\n949abebea0059edd929b653b4b475a5880fc0a3e [fuzz] Avoid collecting initialization coverage (dergoegge)\n\nPull request description:\n\n  Our coverage reports include coverage of initialization code, which can be misleading when trying to evaluate the coverage a fuzz harness achieves through fuzzing alone.\n\n  This PR proposes to make fuzz coverage reports more accurate by resetting coverage counters after initialization code has been run. This makes it easier to evaluate which code was actually reached through fuzzing (e.g. to spot fuzz blockers).\n\nACKs for top commit:\n  maflcko:\n    utACK 949abebea0059edd929b653b4b475a5880fc0a3e\n  brunoerg:\n    nice, utACK 949abebea0059edd929b653b4b475a5880fc0a3e\n\nTree-SHA512: c8579bda4f3d71d199b9331fbe6316fce375a906743d0bc216bb94958dc03fdc9a951ea50cfeb487494a75668ae3c16471a82f7e5fdd912d781dc29d063e2c5b","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2312521436\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30156\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30156/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30156\">#30156</a>: fuzz: More accurate coverage reports"}},{"before":"327f08bb0cd91a22249395adeb34549e3c86ca76","after":"58956028e4398a33a3bd7ba00aebe03bb589910f","ref":"refs/heads/master","pushedAt":"2024-05-29T08:22:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30170: refactor: Use type-safe time in txorphanage\n\nfa6d4891c7815025ab1cd58d0906466af31bb648 refactor: Use type-safe time in txorphanage (MarcoFalke)\n\nPull request description:\n\n  This allows to remove manual conversions like multiplication by `60`, and uses a type-safe type instead of a raw `int64_t`.\n\nACKs for top commit:\n  epiccurious:\n    utACK fa6d4891c7815025ab1cd58d0906466af31bb648.\n  dergoegge:\n    Code review ACK fa6d4891c7815025ab1cd58d0906466af31bb648\n  brunoerg:\n    utACK fa6d4891c7815025ab1cd58d0906466af31bb648\n\nTree-SHA512: c187d0e579b1131afcef8c901f5662c18ab867fa2a99fbb13b67bb1e10b2047128194bfef8329cde0d51e1c35d6227ae292b823968f37ea9422975e46e01846a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2315289000\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30170\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30170/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30170\">#30170</a>: refactor: Use type-safe time in txorphanage"}},{"before":"c7885ecd778d7e42bc07a0ba73156525e86a8aae","after":"fccd32efe6e2950b2c74fdec2ade54040ca32a2c","ref":"refs/heads/27.x","pushedAt":"2024-05-29T08:17:00.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30092: [27.x] Backports and rc1\n\n22701a43464ab27ea83c8b49e2732ee647909a10 doc: update manual pages for 27.1rc1 (fanquake)\n9e919072bd76b0c2048ef9df6ba7171e8be0ccf4 build: bump version to 27.1rc1 (fanquake)\n9b4640c4bea984ebd496a4d6eb014fab7b6827fc doc: update release-notes.md for 27.1 (fanquake)\n80032d691702f1e5eccb27571066bfc9b2415742 qt: 27.1rc1 translations update (Hennadii Stepanov)\n423bd6dc68df1b023a699cb29825b946387a7b37 windeploy: Renew certificate (Ava Chow)\n77b2321ca03dcbd5f77060510dc8a19e7f4fdfa2 depends: Fetch miniupnpc sources from an alternative website (Hennadii Stepanov)\n31adcfa171c834a63237b4885ae19674fdff16f9 test: add GetAddedNodeInfo() CJDNS regression unit test (Jon Atack)\n9cdb9edfb8d1a4b0c1ba39cea0d5cee2e28e1d31 p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo() (Jon Atack)\n3c26058da223b873094b62c30f2463ab0e629b6a crypto: disable asan for sha256_sse4 with clang and -O0 (Cory Fields)\n0ba11cf90869fb437f6dce0c9430be4f899c0ea1 rpc: move UniValue in blockToJSON (willcl-ark)\ndedf319b08d5b76dc1752d8bc4e14d38dc54e100 gui: don't permit port in proxy IP option (willcl-ark)\nd1289a13006f43afa812f7ee8956f3d59449cfd0 gui: fix create unsigned transaction fee bump (furszy)\n\nPull request description:\n\n  Backports:\n  * https://github.com/bitcoin-core/gui/pull/812\n  * https://github.com/bitcoin-core/gui/pull/813\n  * https://github.com/bitcoin/bitcoin/pull/30085\n  * https://github.com/bitcoin/bitcoin/pull/30094\n  * https://github.com/bitcoin/bitcoin/pull/30097\n  * https://github.com/bitcoin/bitcoin/pull/30149\n  * https://github.com/bitcoin/bitcoin/pull/30151\n\n  Bump to 27.1rc1.\n\nACKs for top commit:\n  stickies-v:\n    re-ACK 22701a43464ab27ea83c8b49e2732ee647909a10\n  willcl-ark:\n    reACK 22701a43464ab27ea83c8b49e2732ee647909a10\n  hebasto:\n    re-ACK 22701a43464ab27ea83c8b49e2732ee647909a10.\n\nTree-SHA512: 6eca44ba7e6664eb4677646597dfdaf56a241c8c3e95e0ab8929ee2fc3671303fc6c2634d359b4523dbd452ac5e54fd1f4c7c2bf7e9c5209395f8cb3b4753fb3","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2291780971\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30092\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30092/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30092\">#30092</a>: [27.x] Backports and rc1"}},{"before":"62c22dd679ba479e56c133b126174234d91bc857","after":"fb9890cbd512b84ab82f482acdf972b13688ce44","ref":"refs/heads/25.x","pushedAt":"2024-05-29T08:06:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30184: [25.x] windeploy: Renew certificate\n\n7a4eff2c98eb41e304cfb03372bce401909bf3d0 windeploy: Renew certificate (Ava Chow)\n\nPull request description:\n\n  Github-Pull: #30149\n  Rebased-From: 9f4ff1e9659597307f62510f1885ad8da3a1d9a3\n\nACKs for top commit:\n  theuni:\n    ACK 7a4eff2c98eb41e304cfb03372bce401909bf3d0\n  glozow:\n    ACK 7a4eff2c98eb41e304cfb03372bce401909bf3d0\n\nTree-SHA512: 827b20fad32a2f140e12595ff297fc29769a6189561f13c06e4b3dc05265f48efbf3185320d436229767918dfda9d7417ec8a39018662379641e3f7828ba93a5","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2321357699\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30184\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30184/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30184\">#30184</a>: [25.x] windeploy: Renew certificate"}},{"before":"4c387cb64ff4c74f911b1559fb0ef143ee6c268b","after":"327f08bb0cd91a22249395adeb34549e3c86ca76","ref":"refs/heads/master","pushedAt":"2024-05-24T17:15:58.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30169: fuzz: Fix wallet_bdb_parser stdlib error matching\n\nfac72985292b516919a216d9a78cf84418cd7f96 fuzz: Fix wallet_bdb_parser stdlib error matching (MarcoFalke)\n\nPull request description:\n\n  The stdlib error string is an implementation detail and can not be relied upon.\n\n  Ref: `libc++abi: terminating due to uncaught exception of type std::runtime_error: AutoFile::read: end of file: unspecified iostream_category error`\n\nACKs for top commit:\n  achow101:\n    ACK fac72985292b516919a216d9a78cf84418cd7f96\n\nTree-SHA512: 588acc71a05d97855d6bb65380411e8486692536434eadee7697de09f80b128ff2f90a31fd0e8384d084b554d2f3978efd076082e070e721cf05b07c94cc83b1","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2315282157\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30169\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30169/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30169\">#30169</a>: fuzz: Fix wallet_bdb_parser stdlib error matching"}},{"before":"0b4aa31c34b239ec7da36760a2670792184c3ba8","after":"6d7a1e3670675fe4bcdd9b2df9bce7979ecd90fc","ref":"refs/heads/26.x","pushedAt":"2024-05-24T10:22:34.000Z","pushType":"push","commitsCount":17,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29899: [26.x] archive 26.1 release notes + backports\n\naa7e876953c460e8ff97a719fdb18f4f3ac4896f [doc] add draft release notes for 26.2rc1 (glozow)\n21d9aaae3226d76094d323c1de8e1470c5384622 p2p, bugfix: detect addnode cjdns peers in GetAddedNodeInfo() (Jon Atack)\nec5ce2fb2b34cdf9691557121faa69298daa97f2 windeploy: Renew certificate (Ava Chow)\n96d0e818c5801d4af5570241cd9949cddbacba5e rpc: Reword SighashFromStr error message (MarcoFalke)\n6685affe92ce61a586d257b3ccdf0d97f8b9ef85 rpc: move UniValue in blockToJSON (willcl-ark)\n7f45e0017417d1a100c60ff02cc72eb788b6f9c6 depends: Fix build of Qt for 32-bit platforms (laanwj)\nf9b76bae57a79f55b3a6eff0a029b5dc21b1730c ci: Pull in qtbase5-dev instead of seperate low-level libraries (laanwj)\nc587753f484d2ccb5b93a7cd37c7a8d491e03818 doc: Suggest installing dev packages for debian/ubuntu qt5 build (laanwj)\n7ecdb0846dd7d5ff66aec961515c552a531d25f8 ci: Bump s390x to ubuntu:24.04 (MarcoFalke)\nd9ef6cf934cbd8e9b2f8256de001ca44f74ad6e9 sign: don't assume we are parsing a sane Miniscript (Antoine Poinsot)\ne4859c82c7b848554b4e9d27c2f8b8615422528e depends: fix mingw-w64 Qt DEBUG=1 build (fanquake)\nbb46b90b2ec7c8a4955ed8c5711bbc128d803b76 Fix #29767, set m_synced = true after Commit() (nanlour)\nbf5b6fc8a7c7e6c13520671bb7b2d4d1d110c2bb Throw error if invalid parameters passed to getnetworkhashps RPC endpoint (Jameson Lopp)\na81a9228fbaaa10d6308299f11d6093485d645e5 [rpc, bugfix] Enforce maximum value for setmocktime (dergoegge)\nd39ea519c71ea9e0f2ed0ee79cc66ecaf35e86ee Change Luke Dashjr seed to dashjr-list-of-p2p-nodes.us (Luke Dashjr)\nc21bbcc898d9c1fbc77ca93e46fc84ae22b68afa [doc] archive 26.1 release notes (glozow)\n\nPull request description:\n\n  Archives 26.1 release notes and adds draft release notes for 26.2rc1\n\n  Also backports:\n  - #29691\n  - #29869\n  - #28554\n  - #29747\n  - #29853\n  - #29856\n  - #29764\n  - #29776\n  - #29985\n  - #30094\n  - #29870\n  - #30149\n  - #30085\n\nACKs for top commit:\n  stickies-v:\n    re-ACK aa7e876953c460e8ff97a719fdb18f4f3ac4896f, only changes are fixing commit msg and transifex reference\n  willcl-ark:\n    ACK aa7e876953c460e8ff97a719fdb18f4f3ac4896f\n\nTree-SHA512: b81ba6092640de696d782114cdf43e7ed1d63ea0a3231cade30653c2743d87700e0f852a1b1fcc42ae313b2d4f004e6026ddbad87d58c2fde0a660e90026ed98","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2248182147\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29899\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29899/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29899\">#29899</a>: [26.x] archive 26.1 release notes + backports"}},{"before":"413844f1c2a3d8f7cfef822f348f26df488b03c7","after":"4c387cb64ff4c74f911b1559fb0ef143ee6c268b","ref":"refs/heads/master","pushedAt":"2024-05-24T09:25:23.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30072: refactor prep for package rbf\n\n2fd34ba504957331f5a08614b6e1f8317260f04d Add sanity checks for various ATMPArgs booleans (Greg Sanders)\n20d8936d8bb6137a5a3722d34e0d7ae756031009 [refactor] make some members MemPoolAccept-wide (glozow)\ncbbfe719b223b9e05398227cef68c99eb97670bd cpfp carveout is excluded in packages (glozow)\n69f7ab05bafec1cf06fd7a58351f78e32bbfa2cf Add m_allow_sibling_eviction as separate ATMPArgs flag (Greg Sanders)\n57ee3029ddadaee5cb48224e0a87f704b7971bd8 Add description for m_test_accept (Greg Sanders)\n\nPull request description:\n\n  First few commits of https://github.com/bitcoin/bitcoin/pull/28984 to set the stage for the package RBF logic.\n\n  These refactors are preparation for evaluating an RBF in a multi-proposed-transaction context instead of only a single proposed transaction. Also, carveouts and sibling evictions only should work in single RBF cases so add logic to preclude multi-tx cases in the future.\n\n  No behavior changes aside from bailing earlier from failed carve-outs.\n\nACKs for top commit:\n  glozow:\n    reACK 2fd34ba504957331f5a08614b6e1f8317260f04d via range-diff\n  sr-gi:\n    utACK [2fd34ba](https://github.com/bitcoin/bitcoin/pull/30072/commits/2fd34ba504957331f5a08614b6e1f8317260f04d)\n  theStack:\n    re-ACK 2fd34ba504957331f5a08614b6e1f8317260f04d\n\nTree-SHA512: 5071c5b8d9b8d2c9faa278c8c4df31de288cb407a68e4d55544c588caff6c86160cce7825453549c6ed69e29d9ccb5ee2d4a518b18f563bfb12f2ced073fe42a","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2287756925\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30072\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30072/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30072\">#30072</a>: refactor prep for package rbf"}},{"before":"915d7276e4060999bac2a42c533b6fb8bdbe5b3d","after":"413844f1c2a3d8f7cfef822f348f26df488b03c7","ref":"refs/heads/master","pushedAt":"2024-05-23T16:31:32.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29612: rpc: Optimize serialization and enhance metadata of dumptxoutset output\n\n542e13b2937356810bda2c41be83c3b1675e2f2f rpc: Enhance metadata of the dumptxoutset output (Fabian Jahr)\n4d8e5edbaa94805be41ae4c8aa2f4bf7aaa276fe assumeutxo: Add documentation on dumptxoutset serialization format (Fabian Jahr)\nc14ed7f384075330361df636f40121cf25a066d6 assumeutxo: Add test for changed coin size value (Fabian Jahr)\nde95953d870c41436de67d56c93259bc66fe1434 rpc: Optimize serialization disk space of dumptxoutset (Fabian Jahr)\n\nPull request description:\n\n  The second attempt at implementing the `dumptxoutset` space optimization as suggested in #25675. Closes #25675.\n\n  This builds on the work done in #26045, addresses open feedback, adds some further improvements (most importantly usage of compact size), documentation, and an additional test.\n\n  The [original snapshot at height 830,000](https://github.com/bitcoin/bitcoin/pull/29551) came in at 10.82 GB. With this change, the same snapshot is 8.94 GB, a reduction of 17.4%.\n\n  This also enhances the metadata of the output file and adds the following data to allow for better error handling and make future upgrades easier:\n  - A newly introduced utxo set magic\n  - A version number\n  - The network magic\n  - The block height\n\nACKs for top commit:\n  achow101:\n    ACK 542e13b2937356810bda2c41be83c3b1675e2f2f\n  TheCharlatan:\n    Re-ACK 542e13b2937356810bda2c41be83c3b1675e2f2f\n  theStack:\n    ACK 542e13b2937356810bda2c41be83c3b1675e2f2f\n\nTree-SHA512: 0825d30e5c3c364062db3c6cbca4e3c680e6e6d3e259fa70c0c2b2a7020f24a47406a623582040988d5c7745b08649c31110df4c10656aa25f3f27eb35843d99","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2177795926\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29612\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29612/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29612\">#29612</a>: rpc: Optimize serialization and enhance metadata of dum…"}},{"before":"867f6af803dcc9f0f754bf5cc683c853bb09051b","after":"915d7276e4060999bac2a42c533b6fb8bdbe5b3d","ref":"refs/heads/master","pushedAt":"2024-05-23T16:12:05.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#27064: system: use %LOCALAPPDATA% as default datadir on windows\n\n84900ac34f6888b7a851d0a6a5885192155f865c doc: add release-notes-27064.md (Matthew Zipkin)\n855dd8d592c951a2b3239867ffbf66bb8677d470 system: use %LOCALAPPDATA% as default datadir on windows (Matthew Zipkin)\n\nPull request description:\n\n  Closes https://github.com/bitcoin/bitcoin/issues/2391\n\n  This PR changes the default datadir location on Windows from `C:\\Users\\Username\\AppData\\Roaming\\Bitcoin` to `C:\\Users\\Username\\AppData\\Local\\Bitcoin`. This change only applies to fresh installs. To preserve backwards compatibility, on startup we check for the existence of `C:\\Users\\Username\\AppData\\Roaming\\Bitcoin\\chainstate` and if it is there, we continue using the \"Roaming\" directory as the default datadir location.\n\n  [Note that in Windows 11 this change may be moot:](https://learn.microsoft.com/en-us/uwp/api/windows.storage.applicationdata.roamingfolder?view=winrt-22621)\n\n  > Roaming data and settings is no longer supported as of Windows 11. The recommended replacement is [Azure App Service](https://learn.microsoft.com/en-us/azure/app-service/). Azure App Service is widely supported, well documented, reliable, and supports cross-platform/cross-ecosystem scenarios such as iOS, Android and web. Settings stored here no longer roam (as of Windows 11), but the settings store is still available.\n\nACKs for top commit:\n  achow101:\n    ACK 84900ac34f6888b7a851d0a6a5885192155f865c\n  BenWestgate:\n    crACK https://github.com/bitcoin/bitcoin/commit/84900ac34f6888b7a851d0a6a5885192155f865c\n  hebasto:\n    re-ACK 84900ac34f6888b7a851d0a6a5885192155f865c, only addressed feedback since my recent [review](https://github.com/bitcoin/bitcoin/pull/27064#pullrequestreview-2028718273).\n\nTree-SHA512: 807c6e89571287e2c8f4934229aec91ef28e7d0a675234acf1b7d085c24c7b73a08b6e345fbfc9038e6239187b6b69c08490ddaa1c057de5ea975c4a000bba42","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1576774844\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/27064\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/27064/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/27064\">#27064</a>: system: use %LOCALAPPDATA% as default datadir on windows"}},{"before":"6300438a2e0b6ee21fe210072b7b8be2f4845c17","after":"867f6af803dcc9f0f754bf5cc683c853bb09051b","ref":"refs/heads/master","pushedAt":"2024-05-23T15:54:38.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29873: policy: restrict all TRUC (v3) transactions to 10kvB\n\n154b2b2296edccb5ed24e829798dacb6195edc11 [fuzz] V3_MAX_VSIZE and effective ancestor/descendant size limits (glozow)\na29f1df289cf27c6cbd565448548b3dc1392a9b0 [policy] restrict all v3 transactions to 10kvB (glozow)\nd578e2e3540e085942001350ff3aeb047bdac973 [policy] explicitly require non-v3 for CPFP carve out (glozow)\n\nPull request description:\n\n  Opening for discussion / conceptual review.\n\n  We like the idea of a smaller maximum transaction size because:\n  - It lowers potential replacement cost (i.e. harder to do Rule 3 pinning via gigantic transaction)\n  - They are easier to bin-pack in block template production\n  - They equate to a tighter memory limit in data structures that are bounded by a number of transactions (e.g. orphanage and vExtraTxnForCompact). For example, the current memory bounds for orphanage is 100KvB * 100 = 40MB, and guaranteeing 1 tx per peer would require reserving a pretty large space.\n\n  History for `MAX_STANDARD_TX_WEIGHT=100KvB` (copied from https://github.com/bitcoin/bitcoin/pull/29873#issuecomment-2115459510):\n  - 2010-09-13 In https://github.com/bitcoin/bitcoin/commit/3df62878c3cece15a8921fbbdee7859ee9368768 satoshi added a 100kB (MAX_BLOCK_SIZE_GEN/5 with MBS_GEN = MAX_BLOCK_SIZE/2) limit on new transactions in CreateTransaction()\n  - 2013-02-04 https://github.com/bitcoin/bitcoin/pull/2273 In gavin gave that constant a name, and made it apply to transaction relay as well\n\n  Lowering `MAX_STANDARD_TX_WEIGHT` for all txns is not being proposed, as there are existing apps/protocols that rely on large transactions. However, it's been brought up that we should consider this for TRUCs (which is especially designed to avoid Rule 3 pinning).\n\n  This reduction should be ok because using nVersion=3 isn't standard yet, so this wouldn't break somebody's existing use case. If we find that this is too small, we can always increase it later. Decreasing would be much more difficult.\n  ~[Expected size of a commitment transaction](https://github.com/lightning/bolts/blob/master/03-transactions.md#expected-weight-of-the-commitment-transaction) is within (900 + 172 * 483 + 224) / 4 = 21050vB~ EDIT: this is incorrect, but perhaps not something that should affect how we choose this number.\n\nACKs for top commit:\n  sdaftuar:\n    ACK 154b2b2296edccb5ed24e829798dacb6195edc11\n  achow101:\n    ACK 154b2b2296edccb5ed24e829798dacb6195edc11\n  instagibbs:\n    ACK 154b2b2296edccb5ed24e829798dacb6195edc11\n  t-bast:\n    ACK https://github.com/bitcoin/bitcoin/commit/154b2b2296edccb5ed24e829798dacb6195edc11\n  murchandamus:\n    crACK 154b2b2296edccb5ed24e829798dacb6195edc11\n\nTree-SHA512: 89392a460908a8ea9f547d90e00f5181de0eaa9d2c4f2766140a91294ade3229b3d181833cad9afc93a0d0e8c4b96ee2f5aeda7c50ad7e6f3a8320b9e0c5ae97","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2243408177\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29873\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29873/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29873\">#29873</a>: policy: restrict all TRUC (v3) transactions to 10kvB"}},{"before":"e163d864d380956a4c0f89a4d80a76f5aefc9a08","after":"6300438a2e0b6ee21fe210072b7b8be2f4845c17","ref":"refs/heads/master","pushedAt":"2024-05-23T14:53:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"ryanofsky","name":"Ryan Ofsky","path":"/ryanofsky","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/7133040?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30115: rpc: avoid copying into UniValue\n\nd7707d9843b03f20d2a8c5a45d7b3db58e169e6f rpc: avoid copying into UniValue (Cory Fields)\n\nPull request description:\n\n  These are the simple (and hopefully obviously correct) copies that can be moves instead.\n\n  This is a follow-up from https://github.com/bitcoin/bitcoin/pull/30094#issuecomment-2108751842\n\n  As it turns out, there are hundreds of places where we copy UniValues needlessly. It should be the case that moves are always preferred over copies, so there should be no downside to these changes.\n\n  willcl-ark, however, noticed that memory usage may increase in some cases. Logically this makes no sense to me. The only plausible explanation imo is that because the moves are faster, more ops/second occur in some cases.\n\n  This list of moves was obtained by changing the function signatures of the UniValue functions to accept only rvalues, then compiling and fixing them up one by one. There still exist many places where copies are being made. These can/should be fixed up, but weren't done here for the sake of doing the easy ones first.\n\n  I ran these changes through clang-tidy with `performance-move-const-arg` and `bugprone-use-after-move` and no bugs were detected (though that's obviously not to say it can be trusted 100%).\n\n  As stated above, there are still lots of other less trivial fixups to do after these including:\n  - Using non-const UniValues where possible so that moves can happen\n  - Refactoring code in order to be able to move a UniValue without introducing a use-after-move\n  - Refactoring functions to accept UniValues by value rather than by const reference\n\nACKs for top commit:\n  achow101:\n    ACK d7707d9843b03f20d2a8c5a45d7b3db58e169e6f\n  ryanofsky:\n    Code review ACK d7707d9843b03f20d2a8c5a45d7b3db58e169e6f. No changes since last review other than rebase. I agree benchmarks showing increased peak memory usage and RSS are surprising, but number of allocations is down as expected, and runtime is also decreased.\n  willcl-ark:\n    ACK d7707d9843b03f20d2a8c5a45d7b3db58e169e6f\n\nTree-SHA512: 7f511be73984553c278186286a7d161a34b2574c7f5f1a0edc87c2913b4c025a0af5241ef9af2df17547f2e4ef79710aa5bbb762fc9472435781c0488dba3435","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2298612841\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30115\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30115/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30115\">#30115</a>: rpc: avoid copying into UniValue"}},{"before":"f15778536ad421f9805f0c005f0eb7b84dda1b4e","after":"e163d864d380956a4c0f89a4d80a76f5aefc9a08","ref":"refs/heads/master","pushedAt":"2024-05-23T14:00:49.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30118: test: improve robustness of connect_nodes()\n\n6629d1d0f8285d1bf2d87341a856abe903f26c13 test: improve robustness of connect_nodes() (furszy)\n\nPull request description:\n\n  Decoupled from #27837 because this can help other too, found it investigating a CI failure https://cirrus-ci.com/task/5805115213348864?logs=ci#L3200.\n\n  The `connect_nodes` function in the test framework relies on a stable number of peer\n  connections to verify that the new connection between the nodes is successfully established.\n  This approach is fragile, as any of the peers involved in the process can drop, lose, or\n  create a connection at any step, causing subsequent `wait_until` checks to stall indefinitely\n  even when the peers in question were connected successfully.\n\n  This commit improves the situation by using the nodes' subversion and the connection\n  direction (inbound/outbound) to identify the exact peer connection and perform the\n  checks exclusively on it.\n\nACKs for top commit:\n  stratospher:\n    reACK 6629d1d.\n  achow101:\n    ACK 6629d1d0f8285d1bf2d87341a856abe903f26c13\n  maflcko:\n    utACK 6629d1d0f8285d1bf2d87341a856abe903f26c13\n  AngusP:\n    re-ACK 6629d1d0f8285d1bf2d87341a856abe903f26c13\n\nTree-SHA512: 5f345c0ce49ea81b643e97c5cffd133e182838752c27592fcdeac14ad10919fb4b7ff38e289e42a7c3c638a170bd0d0b7a9cd493898997a2082a7b7ceef4aeeb","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2298831649\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30118\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30118/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30118\">#30118</a>: test: improve robustness of connect_nodes()"}},{"before":"83ae1bac9d3e01de994734b4bc7002deaf19bc67","after":"f15778536ad421f9805f0c005f0eb7b84dda1b4e","ref":"refs/heads/master","pushedAt":"2024-05-23T12:25:18.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30149: contrib: Renew Windows code signing certificate\n\n9f4ff1e9659597307f62510f1885ad8da3a1d9a3 windeploy: Renew certificate (Ava Chow)\n\nPull request description:\n\n  Renewed the Windows code signing certificate for another 3 years.\n\nACKs for top commit:\n  fanquake:\n    ACK 9f4ff1e9659597307f62510f1885ad8da3a1d9a3\n  glozow:\n    tested ACK 9f4ff1e96595\n\nTree-SHA512: 6441aa55fa1aa4e532bbe1ce1ad8b9be8a197d8de0aa57a8b02d41681a433599f305eb0a519e90782cebe20f473322be519ff6398933f525c39cc3476e860283","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2309516987\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30149\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30149/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30149\">#30149</a>: contrib: Renew Windows code signing certificate"}},{"before":"ef44726918c05e158246cb695ae358db603653e9","after":"83ae1bac9d3e01de994734b4bc7002deaf19bc67","ref":"refs/heads/master","pushedAt":"2024-05-23T11:08:49.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"glozow","name":"Gloria Zhao","path":"/glozow","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/25183001?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30062: net: add ASMap info in `getrawaddrman` RPC\n\n1e54d61c4698debf3329d1960e06078ccbf8063c test: add coverage for `mapped_as` from `getrawaddrman` (brunoerg)\n8c2714907d1e1ffc58487b3b43e018c1ec10065b net: rpc: return peer's mapped AS in getrawaddrman (brunoerg)\n\nPull request description:\n\n  This PR adds two new fields in `getrawaddrman` RPC: \"mapped_as\" and \"source_mapped_as\". These fields are used to return the ASN (Autonomous System Number) mapped to the peer and its source. With these informations we can have a better view of the bucketing logic with ASMap specially in projects like [addrman-observer](https://github.com/0xb10c/addrman-observer).\n\nACKs for top commit:\n  fjahr:\n    Code review ACK 1e54d61c4698debf3329d1960e06078ccbf8063c\n  virtu:\n    ACK [1e54d61](https://github.com/bitcoin/bitcoin/commit/1e54d61c4698debf3329d1960e06078ccbf8063c)\n  0xB10C:\n    ACK 1e54d61c4698debf3329d1960e06078ccbf8063c\n  glozow:\n    ACK 1e54d61c4698debf3329d1960e06078ccbf8063c\n\nTree-SHA512: af86bcc7a2e69bebd3fa9eaa2e527e0758c44c0a958de7292514d5f99f8f01f5df3bae11400451268e0255f738ff3acccc77f48fe129937512f1e9d9963c4c5e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2285443527\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30062\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30062/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30062\">#30062</a>: net: add ASMap info in <code>getrawaddrman</code> RPC"}},{"before":"6f36624147dfb59603698db647b4ad612b771810","after":"ef44726918c05e158246cb695ae358db603653e9","ref":"refs/heads/master","pushedAt":"2024-05-23T08:39:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30151: depends: Fetch miniupnpc sources from an alternative website\n\n21b8a14d37c19ce292d5529597e0d52338db48a9 depends: Fetch miniupnpc sources from an alternative website (Hennadii Stepanov)\n\nPull request description:\n\n  The https://miniupnp.tuxfamily.org website is unavailable now.\n\nACKs for top commit:\n  achow101:\n    ACK 21b8a14d37c19ce292d5529597e0d52338db48a9\n  edilmedeiros:\n    utACK 21b8a14d37c19ce292d5529597e0d52338db48a9\n  theuni:\n    utACK 21b8a14d37c19ce292d5529597e0d52338db48a9\n\nTree-SHA512: 141427447d5f1902f17fe3774fadf0ac912f663d7fd6467dff42fd6131f6884906b77cf49bbe7387f118fd9e9d52af1d36778624f9f02237d2ba3387fc974be6","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2310015134\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30151\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30151/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30151\">#30151</a>: depends: Fetch miniupnpc sources from an alternative we…"}},{"before":"93bec6e953172c14fc65aa1e9e363a5a9188ba37","after":"6f36624147dfb59603698db647b4ad612b771810","ref":"refs/heads/master","pushedAt":"2024-05-22T13:43:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30150: doc: Correct pull request prefix for scripts and tools\n\nfa3e1151a28345edff8f371283745bdd647f9a74 doc: Correct pull request prefix for scripts and tools (MarcoFalke)\n\nPull request description:\n\n  `script` is confusing, because in the context of Bitcoin, it usually means Bitcoin script (c.f. `CScript` in `script.h`, or pull requests such as https://github.com/bitcoin/bitcoin/pull/27122 using the prefix).\n\n  This could be fixed by renaming it to `scripts` (with a plural `s` at the end), however, looking at the current usage `contrib` and `cli` seem more common (https://github.com/bitcoin/bitcoin/pull/29687, https://github.com/bitcoin/bitcoin/pull/26953, https://github.com/bitcoin/bitcoin/pull/26584, https://github.com/bitcoin/bitcoin/pull/24864, https://github.com/bitcoin/bitcoin/pull/30074, https://github.com/bitcoin/bitcoin/pull/29433 ...)\n\nACKs for top commit:\n  fanquake:\n    ACK fa3e1151a28345edff8f371283745bdd647f9a74\n  willcl-ark:\n    ACK fa3e1151a28345edff8f371283745bdd647f9a74\n  hebasto:\n    ACK fa3e1151a28345edff8f371283745bdd647f9a74.\n  theuni:\n    ACK fa3e1151a28345edff8f371283745bdd647f9a74\n\nTree-SHA512: fb3a3892ca5f859e590c8a620350c397ef1f9eafd9e174c70ef50095d401a396758d6c93ad41888da8025c41e25e691f30c18f9e974af13597f2266bb2c53b6d","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2309860823\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30150\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30150/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30150\">#30150</a>: doc: Correct pull request prefix for scripts and tools"}},{"before":"fa8cb0516d4198c56d3dc1252a5a899959e279aa","after":"93bec6e953172c14fc65aa1e9e363a5a9188ba37","ref":"refs/heads/master","pushedAt":"2024-05-22T12:43:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30131: wallet, tests: Avoid stringop-overflow warning in PollutePubKey\n\n2289d4524053ab71c0d9133987cb36412797c1a2 wallet, tests: Avoid stringop-overflow warning in PollutePubKey (Ava Chow)\n\nPull request description:\n\n  Fixes  #30114\n\nACKs for top commit:\n  maflcko:\n    ACK 2289d4524053ab71c0d9133987cb36412797c1a2 with g++ 14.1.1 🦄\n  theStack:\n    utACK 2289d4524053ab71c0d9133987cb36412797c1a2\n  laanwj:\n    ACK 2289d4524053ab71c0d9133987cb36412797c1a2\n\nTree-SHA512: 173c3c299bdd890f73e8a67a37880dbf816265e8b3c8298557ef2fc4670f5447005c0d2d81726f9bc43f6a69d677365d90a604354b3cbab0e3c52c4526d0407e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2303357272\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30131\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30131/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30131\">#30131</a>: wallet, tests: Avoid stringop-overflow warning in Pollu…"}},{"before":"0388dd702b8d76c83bd17fc339d8c63904234fb0","after":"fa8cb0516d4198c56d3dc1252a5a899959e279aa","ref":"refs/heads/master","pushedAt":"2024-05-22T08:20:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30144: ci: Add mising -Wno-error=maybe-uninitialized to armhf task\n\nfa73431dd4709754c34a4d5ad1c940ff9e628cf3 ci: Add mising -Wno-error=maybe-uninitialized to armhf task (MarcoFalke)\n\nPull request description:\n\n  This happens after bd597c33e3e58cd3c6b22ed42f8f1fd7ff886bb2 in many pull requests as a silent merge conflict. For example:\n\n  * https://github.com/bitcoin/bitcoin/pull/29720#issuecomment-2120847661\n  * https://github.com/bitcoin/bitcoin/pull/29521#issuecomment-2106542236\n  * (Probably many undetected, because the CI task was not yet re-run)\n  * ...\n\nACKs for top commit:\n  fjahr:\n    utACK fa73431dd4709754c34a4d5ad1c940ff9e628cf3\n  fanquake:\n    ACK fa73431dd4709754c34a4d5ad1c940ff9e628cf3 - many fixed with 13.x\n\nTree-SHA512: 6e6ff8dc6f3c6a2abcd04c4203d3468f6e98c1ad3a4da4ad0037a9ee2cbec6bec079a5f778aba0273e38e173849927abcdfcfba7643d08ed66c1168cb89fab08","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2307281852\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30144\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30144/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30144\">#30144</a>: ci: Add mising -Wno-error=maybe-uninitialized to armhf …"}},{"before":"2ec0a28a37dbb50d463899f53c28fb96905d97b7","after":"0388dd702b8d76c83bd17fc339d8c63904234fb0","ref":"refs/heads/master","pushedAt":"2024-05-22T07:50:47.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30120: Update libsecp256k1 subtree to current master\n\na057869aa3c42457570765966cb66accb2375b13 build: pass --with-ecmult-gen-kb=86 to secp256k1 (fanquake)\nca3d945dc66e177e8fa3e83c77236de89cc0072a Squashed 'src/secp256k1/' changes from d8311688bd..06bff6dec8 (fanquake)\n\nPull request description:\n\n  This includes changes from the 0.5.0 release: https://github.com/bitcoin-core/secp256k1/releases/tag/v0.5.0\n\n  > New function secp256k1_ec_pubkey_sort that sorts public keys using lexicographic (of compressed serialization) order.\n\n  > The implementation of the point multiplication algorithm used for signing and public key generation was changed, resulting in improved performance for those operations.\n  >    The related configure option --ecmult-gen-precision was replaced with --ecmult-gen-kb (ECMULT_GEN_KB for CMake).\n  >    This changes the supported precomputed table sizes for these operations. The new supported sizes are 2 KiB, 22 KiB, or 86 KiB (while the old supported sizes were 32 KiB, 64 KiB, or 512 KiB).\n\nACKs for top commit:\n  hebasto:\n    ACK a057869aa3c42457570765966cb66accb2375b13, I've got a zero diff with my local branch, which reproduces the subtree update, and `ecmult gen table size   = 86 KiB` in the configure summary.\n  jonasnick:\n    utACK a057869aa3c42457570765966cb66accb2375b13\n\nTree-SHA512: 907012b0d7e0a6bd68b245c238e968f2318d8ac5de5ec9070245de8391c996eb5ec6428184d028f6f0f54d3b2f5a8292ad7081177e1c331397879505436dc38e","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2299240114\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30120\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30120/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30120\">#30120</a>: Update libsecp256k1 subtree to current master"}},{"before":"6c13b1375f8fd810f46f5650e01a464ee63cfa46","after":"2ec0a28a37dbb50d463899f53c28fb96905d97b7","ref":"refs/heads/master","pushedAt":"2024-05-21T20:14:35.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30137: build: Remove `--enable-threadlocal`\n\n17fe948cce2eb75f0f3f4b0db9d0d90648c7d4af build: remove --enable-threadlocal (fanquake)\n1e7c20bc19a216269c646177ab90cfa084c096a5 doc: remove comment about using thread_local (fanquake)\n5bba43312c0ceccfe18bd4d086e12ec0497ed926 build: Enable `thread_local` for MinGW-w64 builds (Hennadii Stepanov)\n\nPull request description:\n\n  Includes a commit from #30099.\n  Closes #29952.\n\nACKs for top commit:\n  laanwj:\n    Code review ACK 17fe948cce2eb75f0f3f4b0db9d0d90648c7d4af\n  maflcko:\n    utACK 17fe948cce2eb75f0f3f4b0db9d0d90648c7d4af\n  hebasto:\n    ACK 17fe948cce2eb75f0f3f4b0db9d0d90648c7d4af.\n  theuni:\n    utACK 17fe948cce2eb75f0f3f4b0db9d0d90648c7d4af\n\nTree-SHA512: 2aad6d19e79c4d6d7aefd0f41b215ac8d9320f5908808221d78e6ee1c77503832a02759bee2ad397e235b6739e22aca8dcf5c5ef8854deb8c697b18ac56a06da","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2303817862\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30137\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30137/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30137\">#30137</a>: build: Remove <code>--enable-threadlocal</code>"}},{"before":"a786fd2041913d82ca90b561de309421bd24e41b","after":"6c13b1375f8fd810f46f5650e01a464ee63cfa46","ref":"refs/heads/master","pushedAt":"2024-05-21T17:59:46.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"achow101","name":"Ava Chow","path":"/achow101","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3782274?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#29421: net: make the list of known message types a compile time constant\n\nb3efb486732f3caf8b8a8e9d744e6d20ae4255ef protocol: make message types constexpr (Vasil Dimov)\n2fa9de06c2c8583ee8e2434dc97014b26e218ab5 net: make the list of known message types a compile time constant (Vasil Dimov)\n\nPull request description:\n\n  Turn the `std::vector` to `std::array` because it is cheaper and allows us to have the number of the messages as a compile time constant: `ALL_NET_MESSAGE_TYPES.size()` which can be used in future code to build other `std::array`s with that size.\n\n  ---\n\n  This change is part of https://github.com/bitcoin/bitcoin/pull/29418 but it makes sense on its own and would be good to have it, regardless of the fate of https://github.com/bitcoin/bitcoin/pull/29418. Also, if this is merged, that would reduce the size of https://github.com/bitcoin/bitcoin/pull/29418, thus the current standalone PR.\n\nACKs for top commit:\n  achow101:\n    ACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef\n  jonatack:\n    ACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef\n  maflcko:\n    utACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef 🎊\n  willcl-ark:\n    ACK b3efb486732f3caf8b8a8e9d744e6d20ae4255ef\n\nTree-SHA512: 6d3860c138c64514ebab13d97ea67893e2d346dfac30a48c3d9bc769a1970407375ea4170afdb522411ced306a14a9af4eede99e964d1fb1ea3efff5d5eb57af","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2129040167\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/29421\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/29421/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/29421\">#29421</a>: net: make the list of known message types a compile tim…"}},{"before":"8804ec736adaacf5392392add003e679069ad527","after":"a786fd2041913d82ca90b561de309421bd24e41b","ref":"refs/heads/master","pushedAt":"2024-05-21T09:26:52.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"fanquake","name":"fanquake","path":"/fanquake","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/863730?s=80&v=4"},"commit":{"message":"Merge bitcoin/bitcoin#30143: doc: Update NetBSD Build Guide\n\n85e480a41ad0901a8b46759e921c187ebbbcccdf doc: Update NetBSD Build Guide (Hennadii Stepanov)\n\nPull request description:\n\n  This PR updates the NetBSD Build Guide to reflect:\n  - the recent NetBSD Release\n  - GCC minimum supported version update (https://github.com/bitcoin/bitcoin/pull/28348 and https://github.com/bitcoin/bitcoin/pull/29091)\n  - Python minimum supported version update (https://github.com/bitcoin/bitcoin/pull/28211)\n\n  Also a smaller package set has been suggested:\n  - `boost-headers` instead of the full `boost`\n  - `qt5-qtbase qt5-qttools` instead of the full `qt5` (similar to https://github.com/bitcoin/bitcoin/pull/29932 and https://github.com/bitcoin/bitcoin/pull/29947).\n\nACKs for top commit:\n  maflcko:\n    utACK 85e480a41ad0901a8b46759e921c187ebbbcccdf\n\nTree-SHA512: 0848b6f169a00f2da78eea452fd116193aece853680f4e615ba1df654246ec2a9d1600a4cfb238eb9305b72bbe4b2873519bf1e2987eaaf48aba900c64e85a48","shortMessageHtmlLink":"Merge <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2305844674\" data-permission-text=\"Title is private\" data-url=\"https://github.com/bitcoin/bitcoin/issues/30143\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/bitcoin/bitcoin/pull/30143/hovercard\" href=\"https://github.com/bitcoin/bitcoin/pull/30143\">#30143</a>: doc: Update NetBSD Build Guide"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWR2TFQA","startCursor":null,"endCursor":null}},"title":"Activity · bitcoin/bitcoin"}