React to ref changes #1132
Open
React to ref changes #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a ref callback
- Re-run the effect when the ref changes
- Updated docs
- Fix: TS doesn't actually infer the type of the ref
automatically, this was already the case regardless of whether the
ref is a ref object or a ref callback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Nice! |
|
@JohannesKlauss I would be most grateful if you could review this PR. 🙏 In the meantime, I've worked around this by applying my changes to my project using yarn's package patching feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reacting to ref changes, it's easiest when:
setStatefunction directly as a callback ref function.I reused the test from #1117.
Fixes #1116.