Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PSA] You probably want equal instead of + (plus/bracketright) #1134

Open
lb-pendula opened this issue Feb 9, 2024 · 1 comment
Open

[PSA] You probably want equal instead of + (plus/bracketright) #1134

lb-pendula opened this issue Feb 9, 2024 · 1 comment
Labels
Version 5.x These tickets will be solved in Version 5.x

Comments

@lb-pendula
Copy link

I'm posting this as I was at first utterly baffled when trying to make a hotkey combo of meta and plus, and the docs did not lead me in the right direction. It was only when I put some logging inside the lib itself that I realised I really wanted the equal key and that my desired hotkey could be described as meta+equal (complementing my meta+minus key that worked fine).

I suspect this is a common mistake that devs who don't normally work with a lot of hotkeys (such as myself) forget that keys should usually be nominated by their standard function and not their modified function.

If the docs could be updated in a way that highlights this pitfall I think it would save a lot of issues being filed for hotkeys that don't work :)

@JohannesKlauss
Copy link
Owner

This is a layout specific problem that gets addressed in version 5.

This has been fixed in pre release 5.0.0-1. Please try out this version.
To listen to = use you just use useHotkeys('=', callback, {useKey: true})

Please let me know if that fixes your issue.

@JohannesKlauss JohannesKlauss added the Version 5.x These tickets will be solved in Version 5.x label Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Version 5.x These tickets will be solved in Version 5.x
Projects
None yet
Development

No branches or pull requests

2 participants