Fix default value for mapKey

[nperez0111]

I ran into an issue using this library in IE11, luckily enough it was a very simple fix.

For some reason, I get undefined values in the mapKey functions and get the error:

Unable to get property 'trim' of undefined or null reference

So this fix just sets a default value for the mapKey function to ensure it never hits that error.

Normally, I'd just patch this on my own (no need for every package to support IE11 like I have to), but it was such a simple guard that I figured someone else would run into it eventually and it doesn't bloat anything.

I appreciate your work here, and hope you have a nice day!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-hotkeys-hook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 10, 2024 10:21am

[JohannesKlauss]

Thank you for your contribution, but this is not a sufficient fix. The typing of key is string so it shouldn't be undefined. If it is, the issue is somewhere else.

[nperez0111]

Thank you for your contribution, but this is not a sufficient fix. The typing of key is string so it shouldn't be undefined. If it is, the issue is somewhere else.

I'm sorry but it is a bit hard to understand which key you are referring to.

If you are referring to your mapKey function, then we can easily modify that to say it accepts undefined now (e.g.key?: string).

But, I can assure that at runtime in IE11 (which may have non-standard event codes & key mappings given how old and out of spec it is) we do run into an undefined where a string should be.

Again, thank you for your time. I'll modify the PR to include the more liberal key type