Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Reduce redundant diff comments #482

@ursulean

Description

@ursulean

The action is often leaving review comments which boil down to LGTM. The diff that is added is identical to the diff of the PR, and there is no suggestion made (see screenshot example below).

image

This happens even with the following workflow input parameters:

        with:
          debug: false
          review_simple_changes: false
          review_comment_lgtm: false
          openai_light_model: "gpt-4"

Intuitively, review_simple_changes and review_comment_lgtm being set to false should prevent this from happening, but these comments sometimes make up 50% of all review comments left and really clutter up the PR. I also tried to adjust the summary and system_message inputs to specifically instruct it to avoid commenting on diffs which don't require changes, but this did not help.

Using debug mode, I found the following snippet, which seems (to me) to cause this behavior, and which is not surfaced as a configurable input to the action.

'Below the summary, I would also like you to triage the diff as `NEEDS_REVIEW` or \n' +
        '`APPROVED` based on the following criteria:\n' +
        '\n' +
        '- If the diff involves any modifications to the logic or functionality, even if they \n' +
        '  seem minor, triage it as `NEEDS_REVIEW`. This includes changes to control structures, \n' +
        '  function calls, or variable assignments that might impact the behavior of the code.

Would it be possible to change the wording here depending on review_simple_changes or review_comment_lgtm?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions