Skip to content

Enable central package management in repo #3333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jun 10, 2025
Merged

Enable central package management in repo #3333

merged 23 commits into from
Jun 10, 2025
+275 −260

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented May 7, 2025 •
edited
Loading

Onboarding to modern central package management solution. For reference: https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management#enabling-central-package-management

Also fixed #3330

@cheenamalhotra
Switch to Central Package Management
402553f
@cheenamalhotra
Additional changes
08fd276
@cheenamalhotra
EOF
Loading
Loading status checks…
26b84ec
@cheenamalhotra cheenamalhotra requested a review from a team May 7, 2025 00:32
@cheenamalhotra cheenamalhotra added this to the 6.1-preview2 milestone May 7, 2025
@cheenamalhotra
Handle NU1009
Loading
Loading status checks…
b136264
@Tornhoof
Copy link

Tornhoof commented May 7, 2025

Personally I'd recommend enabling transivite pinning too:
https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management#transitive-pinning
to allow for e.g. specific versions of transitive packages without e.g. security vulnerabilities.

paulmedynski
paulmedynski requested changes May 7, 2025
View reviewed changes
Copy link
Contributor

@paulmedynski paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some formatting nits.

@cheenamalhotra
Enable pinning, fix version
Loading
Loading status checks…
89522cd
@cheenamalhotra
Disable implicit framework reference.
Loading
Loading status checks…
3959e6f
@cheenamalhotra
Fix line break
Loading
Loading status checks…
9c64193
@cheenamalhotra cheenamalhotra requested review from paulmedynski and a team May 7, 2025 15:52
@cheenamalhotra cheenamalhotra mentioned this pull request May 7, 2025
Closed
@cheenamalhotra
Ref fx assemblies
Loading
Loading status checks…
580323e
paulmedynski
paulmedynski previously approved these changes May 7, 2025
View reviewed changes
benrr101
benrr101 previously approved these changes May 7, 2025
View reviewed changes
Copy link
Contributor

@benrr101 benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's not bad. It's kinda doing the same thing we were doing just with built-in support.

mdaigle
mdaigle reviewed May 7, 2025
View reviewed changes
Copy link
Contributor

@mdaigle mdaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some notes on things that changed.

cheenamalhotra and others added 4 commits May 7, 2025 15:52
@cheenamalhotra
try again
Loading
Loading status checks…
49e1298
@cheenamalhotra
Fix source
Loading
Loading status checks…
f9f0172
@cheenamalhotra
Fix package version for MDS test package
Loading
Loading status checks…
58e91c8
@cheenamalhotra
Merge branch 'main' into dev/cheena/central-package-mgmnt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
2ddb065
@cheenamalhotra cheenamalhotra dismissed stale reviews from benrr101 and paulmedynski via 2ddb065 May 20, 2025 10:46
paulmedynski
paulmedynski previously approved these changes May 20, 2025
View reviewed changes
@cheenamalhotra cheenamalhotra self-assigned this May 28, 2025
@benrr101
Merge branch 'main' into dev/cheena/central-package-mgmnt
Loading
Loading status checks…
dc931f8
@benrr101
Copy link
Contributor

@cheenamalhotra Hope you don't mind I resolved your merge conflict for you - just want to get this out the door for the preview release

paulmedynski
paulmedynski previously approved these changes May 30, 2025
View reviewed changes
@cheenamalhotra
Fix dependencies
Loading
Loading status checks…
a958c7a
cheenamalhotra and others added 2 commits June 4, 2025 10:55
@cheenamalhotra
Merge branch 'main' into dev/cheena/central-package-mgmnt

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
89bed36
@cheenamalhotra
Fix project builds
Loading
Loading status checks…
049c67c
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (55095ef) to head (e0197bc).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #3333       +/-   ##
===========================================
+ Coverage   65.34%   92.58%   +27.23%     
===========================================
  Files         300        6      -294     
  Lines       65603      310    -65293     
===========================================
- Hits        42871      287    -42584     
+ Misses      22732       23    -22709
Flag Coverage Δ
addons 92.58% <ø> (ø)
netcore ?
netfx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

paulmedynski
paulmedynski previously approved these changes Jun 5, 2025
View reviewed changes
@cheenamalhotra
Remove version attribute
Loading
Loading status checks…
a89ee55
@cheenamalhotra cheenamalhotra force-pushed the dev/cheena/central-package-mgmnt branch from fd41121 to a89ee55 Compare June 5, 2025 14:48
@cheenamalhotra
Merge branch 'main' into dev/cheena/central-package-mgmnt
Loading
Loading status checks…
e05c05e
@cheenamalhotra
Fix Common project
Loading
Loading status checks…
fdc94f8
@cheenamalhotra
Fix version refs
Loading
Loading status checks…
c077cb2
@cheenamalhotra
Fix .NET 9 deps
Loading
Loading status checks…
6ef5a1b
@cheenamalhotra
Fix
Loading
Loading status checks…
c7f677c
@cheenamalhotra cheenamalhotra mentioned this pull request Jun 9, 2025
Merged
paulmedynski
paulmedynski previously approved these changes Jun 9, 2025
View reviewed changes
@cheenamalhotra
Update packages
Loading
Loading status checks…
e0197bc
@cheenamalhotra
Copy link
Member Author

Getting there @paulmedynski , hang on!

@paulmedynski paulmedynski merged commit e037c8a into main Jun 10, 2025
251 checks passed
@paulmedynski paulmedynski deleted the dev/cheena/central-package-mgmnt branch June 10, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benrr101 benrr101

@paulmedynski paulmedynski

@mdaigle mdaigle

Assignees

@cheenamalhotra cheenamalhotra

Labels
None yet
Projects
None yet
Milestone
6.1-preview2
Development

Successfully merging this pull request may close these issues.

Cannot build because of powershell target
5 participants
@cheenamalhotra @Tornhoof @benrr101 @mdaigle @paulmedynski