Skip to content

fix: ensure every action disables git credential persistence #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2025

Conversation

jdbaldry
Copy link
Contributor

@jdbaldry jdbaldry commented Feb 27, 2025

Reduces the possibility of inadvertently leaking the credentials in consuming workflows.

This has the potential to break workflows that rely on the persisted credentials and I haven't checked which ones may be likely to break

Signed-off-by: Jack Baldry jack.baldry@grafana.com

Reduces the possibility of inadvertently leaking the credentials in consuming workflows.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry requested review from a team as code owners February 27, 2025 09:57
@jdbaldry jdbaldry changed the title Ensure every action disables Git credential persistence fix: Ensure every action disables Git credential persistence Feb 27, 2025
@dsotirakis dsotirakis changed the title fix: Ensure every action disables Git credential persistence fix: ensure every action disables git credential persistence Feb 27, 2025
@zerok
Copy link
Contributor

zerok commented Feb 27, 2025

TIL actions/checkout#485

@jdbaldry
Copy link
Contributor Author

Thanks both for reviewing, I can't merge this so please consider merging when you want :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants