chore: adjust package engines versions #6725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package does not even target Node.JS so we could even drop the `node` dependency for `engines. But lets at least allow the current LTS version (22) along side with LTS 20. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
ShGKme
approved these changes
Apr 5, 2025
|
|
||
| - name: Set up npm ${{ steps.package-engines-versions.outputs.npmVersion }} | ||
| run: npm i -g npm@"${{ steps.package-engines-versions.outputs.npmVersion }}" | ||
| node-version-file: package.json |
There was a problem hiding this comment.
But it doesn't support devEngines yet, right?
There was a problem hiding this comment.
There was a problem hiding this comment.
So no but works as long as devEngines are in the upper bound of the engines.
IMHO browser libraries like this do not even need any engine as they only target the browser not Node (in contrast to e.g. vite-config which targets Node).
Comment on lines
+163
to
+176
| "node": "^20.11.0 || ^22", | ||
| "npm": "^10 || ^11" | ||
| }, | ||
| "devEngines": { | ||
| "packageManager": { | ||
| "name": "npm", | ||
| "version": "^10", | ||
| "onFail": "error" | ||
| }, | ||
| "runtime": { | ||
| "name": "node", | ||
| "version": "^22", | ||
| "onFail": "error" | ||
| } |
There was a problem hiding this comment.
I recall having a script to update all libs/apps
skjnldsv
approved these changes
Apr 8, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
This package does not even target Node.JS so we could even drop the
nodedependency for `engines.But lets at least allow the current LTS version (22) along side with LTS 20.
🏁 Checklist
stable8for maintained Vue 2 version.