Skip to content

V1 corepack #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 6, 2025
Merged

V1 corepack #696

merged 1 commit into from
Feb 6, 2025

Conversation

EmrysMyrddin
Copy link
Member

Because of an issue with setup-node action (actions/setup-node#1222), we need to manually update corepack (at least until a proper fix is pushed by maintainers).

The root cause of this is because we run on old Nove version versions which are shipping with outdated corepack version, which are bundled with outdated npm keys...

@EmrysMyrddin EmrysMyrddin changed the base branch from main to v1 February 6, 2025 10:40
@EmrysMyrddin EmrysMyrddin marked this pull request as draft February 6, 2025 10:40
@EmrysMyrddin EmrysMyrddin marked this pull request as ready for review February 6, 2025 10:42
Copy link

changeset-bot bot commented Feb 6, 2025

⚠️ No Changeset found

Latest commit: 55ab635

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@EmrysMyrddin EmrysMyrddin force-pushed the v1-corepack branch 2 times, most recently from 458cb8b to 55ab635 Compare February 6, 2025 12:31
Copy link
Member

@enisdenjo enisdenjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just don't forget to remove the -corepack before merging.

@EmrysMyrddin EmrysMyrddin merged commit 890fef9 into v1 Feb 6, 2025
@EmrysMyrddin EmrysMyrddin deleted the v1-corepack branch February 6, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants