Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/milvus] Set usePasswordFiles=true by default #32642

Merged
merged 9 commits into from
Apr 7, 2025

Conversation

migruiz4
Copy link
Member

Description of the change

Sets default value for usePasswordFiles to true.

Benefits

With this change, the chart will mount the secrets as files by default instead of directly setting them into environment variables.

Possible drawbacks

None

Applicable issues

None

Additional information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
@github-actions github-actions bot added milvus verify Execute verification workflow for these changes bitnami labels Mar 27, 2025
@github-actions github-actions bot requested a review from dgomezleon March 27, 2025 12:40
bitnami-bot and others added 8 commits March 27, 2025 12:43
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
Signed-off-by: Miguel Ruiz <miguel.ruiz@broadcom.com>
@migruiz4 migruiz4 merged commit acd95f9 into main Apr 7, 2025
12 checks passed
@migruiz4 migruiz4 deleted the password-files-milvus branch April 7, 2025 12:14
@github-actions github-actions bot added the solved label Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami milvus solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants