[bitnami/discourse] Support envFrom in install-plugins
#32790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainer Signed-off-by: Emir Aurelio Rios <mskdenigma@gmail.com>
Signed-off-by: Emir Aurelio Rios <mskdenigma@gmail.com>
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
javsalgar
added
verify
Signed-off-by: Bitnami Bot <bitnami.bot@broadcom.com>
dgomezleon
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This allows the initContainer
install-pluginsto use environment variables set via ConfigMap or Secret.Benefits
Sometimes you need to install discourse plugins from private github repositories and you can do so normally by passing your github personal access token in the url of this plugin repo like this:
https://${GITHUBPAT}@github.com/myprivateorg/discoursepluginThat definitely something you'd want to pass as a secret.
Possible drawbacks
Maybe by using
.Values.discourse.extraEnvVarsCMand.Values.discourse.extraEnvVarsSecretwe are passing unnecessary env vars but I also don't see the harm. We could also addValues.install-plugins.*instead.Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.