chore(repo): update gh actions version #30561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 29f976f.
☁️ Nx Cloud last updated this comment at |
There was a problem hiding this comment.
Pull Request Overview
This PR updates GitHub Actions workflows to use the latest v4 versions of various actions.
- Bumps checkout actions from v3 to v4 and adds a new "filter: tree:0" parameter.
- Updates cache actions from v3 to v4.
- Removes the --base and --head parameters from NX commands in the CI configuration.
Comments suppressed due to low confidence (2)
.github/workflows/ci.yml:32
- Please verify that the new 'filter: tree:0' parameter is supported by actions/checkout@v4 and that its usage is intentional.
filter: tree:0
.github/workflows/ci.yml:76
- The removal of the '--base' and '--head' parameters in the format:check command may affect the context in which the check runs. Please confirm that this change is intended.
pnpm nx-cloud record -- nx format:check &
| @@ -85,7 +85,7 @@ jobs: | |||
| pnpm nx run-many -t check-imports check-commit check-lock-files check-codeowners --parallel=1 --no-dte & | |||
| pids+=($!) | |||
|
|
|||
| pnpm nx affected --targets=lint,test,build,e2e,e2e-ci --base=$NX_BASE --head=$NX_HEAD & | |||
| pnpm nx affected --targets=lint,test,build,e2e,e2e-ci & | |||
There was a problem hiding this comment.
The removal of the '--base' and '--head' parameters in the affected command could alter its behavior. Please verify that this modification is aligned with the intended CI logic.
Suggested change
| pnpm nx affected --targets=lint,test,build,e2e,e2e-ci & | |
| pnpm nx affected --targets=lint,test,build,e2e,e2e-ci --base=$BASE_SHA --head=$HEAD_SHA & |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Hardanish-Singh
approved these changes
Apr 8, 2025
JamesHenry
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the versions of
actions/*GH actions to latest v4.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #