Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup: Do not normalize tsconfig path for Windows #30567

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ms-tng
Copy link
Contributor

@ms-tng ms-tng commented Apr 1, 2025

Current Behavior

Rollup build fails on Windows with errors like this:

[plugin rpt2] error TS6059: File '/foo/bar/baz.ts' is not under 'rootDir' 'C:/foo/bar'. 'rootDir' is expected to contain all source files.

This is because since 81fe7bb the tsconfig path passed to rollup-plugin-typescript2 is built using joinPathFragments, which removes the drive letter on Windows.

Expected Behavior

Rollup build should not fail.

@ms-tng ms-tng requested a review from a team as a code owner April 1, 2025 14:30
@ms-tng ms-tng requested a review from Coly010 April 1, 2025 14:30
Copy link

vercel bot commented Apr 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 1, 2025 2:33pm

Copy link

nx-cloud bot commented Apr 1, 2025

View your CI Pipeline Execution ↗ for commit ace339d.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ❌ Failed 24m 42s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=028b5... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 1m 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-01 15:01:24 UTC

@ms-tng
Copy link
Contributor Author

ms-tng commented Apr 1, 2025

The failing check is not related to my change:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant