feat(webpack): set default sassImplementation to sass-embedded #30580
+22
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 44c4cdc.
☁️ Nx Cloud last updated this comment at |
Coly010
added
target: next major version
leosvelperez
reviewed
Apr 2, 2025
| @@ -161,7 +161,6 @@ export interface NxAppRspackPluginOptions { | |||
| * Add an additional chunk for the rspack runtime. Defaults to `true` when `target === 'web'`. | |||
| */ | |||
| runtimeChunk?: boolean; | |||
| // TODO(v21): Make Sass Embedded the default in version 21. | |||
| // TODO(v22): Remove in version 22. | |||
There was a problem hiding this comment.
If the plan is to remove this option for v22, we should add a deprecation message.
| @@ -221,7 +221,6 @@ export interface NxAppWebpackPluginOptions { | |||
| * Use tsconfig-paths-webpack-plugin to resolve modules using paths in the tsconfig file. | |||
| */ | |||
| useTsconfigPaths?: boolean; | |||
| // TODO(v21): Make Sass Embedded the default in version 21. | |||
| // TODO(v22): Remove in version 22. | |||
There was a problem hiding this comment.
Same here about the deprecation notice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
sassImplementationoption for Webpack and Rspack is set tosassby default.sass-embeddedoffers a faster alternative.Expected Behavior
Switch the default
sassImplementationoption tosass-embedded.