Skip to content

feat(webpack): set default sassImplementation to sass-embedded #30580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2025
Merged

feat(webpack): set default sassImplementation to sass-embedded #30580

merged 1 commit into from
Apr 16, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 2, 2025

Current Behavior

The sassImplementation option for Webpack and Rspack is set to sass by default.
sass-embedded offers a faster alternative.

Expected Behavior

Switch the default sassImplementation option to sass-embedded.

@Coly010 Coly010 requested a review from a team as a code owner April 2, 2025 09:03
@Coly010 Coly010 requested a review from leosvelperez April 2, 2025 09:03
@Coly010 Coly010 self-assigned this Apr 2, 2025
@vercel Vercel
Copy link

vercel bot commented Apr 2, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Apr 16, 2025 8:24am

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Apr 2, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 2234e27.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-ci ❌ Failed 39m 38s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-15 16:20:42 UTC

@Coly010 Coly010 added target: next major version To be merged for the next major version release PR status: do not merge This will block a PR from being merged until this tag is removed. labels Apr 2, 2025
leosvelperez
leosvelperez reviewed Apr 2, 2025
View reviewed changes
Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to call this out as a breaking change. Even though they are comparable functionality-wise, sass-embedded only works in selected platforms (the most used ones, but it could still break some setups).

@Coly010 Coly010 removed target: next major version To be merged for the next major version release PR status: do not merge This will block a PR from being merged until this tag is removed. labels Apr 15, 2025
@Coly010 Coly010 force-pushed the rspack/sass-embedded-default branch from 44c4cdc to 2234e27 Compare April 15, 2025 15:37
@Coly010 Coly010 force-pushed the rspack/sass-embedded-default branch from 2234e27 to 8c9ca8a Compare April 16, 2025 08:22
@Coly010 Coly010 requested a review from leosvelperez April 16, 2025 09:25
@Coly010 Coly010 merged commit 6b08136 into master Apr 16, 2025
6 checks passed
@Coly010 Coly010 deleted the rspack/sass-embedded-default branch April 16, 2025 10:06
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leosvelperez leosvelperez leosvelperez approved these changes

Assignees

@Coly010 Coly010

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Coly010 @leosvelperez