feat(core): add support for http based caches #30593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
View your CI Pipeline Execution ↗ for commit 2a84b29.
☁️ Nx Cloud last updated this comment at |
Cammisuli
previously requested changes
Apr 2, 2025
AgentEnder
force-pushed
the
feat/http-cache
branch
3 times, most recently
from
6c1f51d to
12992ab
Compare
AgentEnder
force-pushed
the
feat/http-cache
branch
2 times, most recently
from
4ff722d to
4d6674c
Compare
AgentEnder
force-pushed
the
feat/http-cache
branch
from
4d6674c to
fd735f3
Compare
AgentEnder
requested review from
a team,
FrozenPandaz and
vsavkin
as code owners
FrozenPandaz
requested changes
Apr 8, 2025
e2e/nx/src/cache.test.ts
Outdated
| @@ -19,7 +22,7 @@ import { join } from 'path'; | |||
| describe('cache', () => { | |||
| beforeEach(() => newProject({ packages: ['@nx/web', '@nx/js'] })); | |||
|
|
|||
| afterEach(() => cleanupProject()); | |||
| // afterEach(() => cleanupProject()); | |||
e2e/nx/src/cache.test.ts
Outdated
| const output = runCLI(`build ${projectName}`, { | ||
| env: { | ||
| NX_SELF_HOSTED_REMOTE_CACHE_SERVER: 'http://localhost:3000', | ||
| NX_NATIVE_LOGGING: 'nx::native::cache::http_remote_cache', |
e2e/nx/src/cache.test.ts
Outdated
| @@ -461,6 +513,7 @@ describe('cache', () => { | |||
| } | |||
| } | |||
| }); | |||
| console.log(lines); | |||
e2e/nx/src/cache.test.ts
Outdated
| cacheServer.kill(); | ||
| }); | ||
|
|
||
| it('should request cache from remote cache', async () => { |
There was a problem hiding this comment.
Suggested change
| it('should request cache from remote cache', async () => { | |
| it('should PUT and GET cache from remote cache', async () => { |
| code_header.set_cksum(); // Ensure the checksum is set correctly | ||
| archive | ||
| .append_data(&mut code_header, "code", &code.to_be_bytes()[..]) | ||
| .unwrap(); |
There was a problem hiding this comment.
Why would this fail? Should we handle that?
| trace!("Reading tarball into memory"); | ||
| let archive_bytes = archive.into_inner().unwrap(); | ||
| let buffer = archive_bytes.finish()?; | ||
| // let mut buffer = Vec::new(); |
| trace!("Finished tarball"); | ||
|
|
||
| trace!("Reading tarball into memory"); | ||
| let archive_bytes = archive.into_inner().unwrap(); |
There was a problem hiding this comment.
Can we use a ? here?
Suggested change
| let archive_bytes = archive.into_inner().unwrap(); | |
| let archive_bytes = archive.into_inner()?; |
| .body(buffer) // Convert the bytes to a Vec<u8> for the request body | ||
| .send() | ||
| .await | ||
| .map_err(|e| anyhow::anyhow!("Failed to send request: {}", e))?; |
There was a problem hiding this comment.
Make sure this logs the error/ reponse body so that people know why the remote cache did not upload.
| } else { | ||
| let path_on_disk = output_dir.join(entry_path); | ||
| trace!("Extracting entry to {}", path_on_disk.display()); | ||
| fs::create_dir_all(path_on_disk.parent().unwrap())?; |
AgentEnder
force-pushed
the
feat/http-cache
branch
from
abddbf9 to
5625619
Compare
FrozenPandaz
approved these changes
Apr 9, 2025
AgentEnder
force-pushed
the
feat/http-cache
branch
from
5625619 to
ee96d07
Compare
isaacplmann
reviewed
Apr 9, 2025
Comment on lines
55
to
56
| {% tabs %} | ||
| {% tab title="Nx 20.8+" %} |
There was a problem hiding this comment.
Its weird to have a tabs component with only one tab. It looks like the tab component doesn't handle it well either.
isaacplmann
approved these changes
Apr 9, 2025
AgentEnder
force-pushed
the
feat/http-cache
branch
from
ee96d07 to
61efdbc
Compare
AgentEnder
force-pushed
the
feat/http-cache
branch
from
61efdbc to
018afd8
Compare
AgentEnder
force-pushed
the
feat/http-cache
branch
from
018afd8 to
2a84b29
Compare
FrozenPandaz
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements http based remote caches per the RFC here: #30548