Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix): update setup-tailwind generator to correct import statements #30599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

There are two issues when we generate a remix application with ts solutions:

  1. Running the setup-tailwind generator with a reference project which now is commonly with the pattern @nx/acme throws an error based on the schema.
Property 'project' does not match the schema.'@nx/acme' should match the pattern '^[a-zA-Z].*$'.
  1. The tailwind.css inside of root.tsx causes error with Vite.
app/root.tsx (9:7): "default" is not exported by "app/tailwind.css", imported by "app/root.tsx".

Expected Behavior

The remix project should be able to be referenced similarly to how we handle React.
The tailwind import should not throw an error.

Related Issue(s)

Fixes #30343

@ndcunningham ndcunningham self-assigned this Apr 2, 2025
@ndcunningham ndcunningham requested review from Coly010 and a team as code owners April 2, 2025 20:45
@ndcunningham ndcunningham requested a review from isaacplmann April 2, 2025 20:45
Copy link

vercel bot commented Apr 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Apr 2, 2025 8:57pm

@ndcunningham ndcunningham force-pushed the fix/remix-ts-solution-tailwind branch from 3526072 to be40420 Compare April 2, 2025 20:45
Copy link

nx-cloud bot commented Apr 2, 2025

View your CI Pipeline Execution ↗ for commit be40420.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 4m 45s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=6e50a... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-03 14:19:56 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: @nx/remix:setup-tailwind fails from v20.4.0 onwards
2 participants