Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Local Images example #5774

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

mootari
Copy link
Contributor

@mootari mootari commented Mar 29, 2025

Fixes a typo in the footer text of the Local Images example.

Change type

  • bugfix
  • improvement
  • feature
  • api
  • other

Test plan

n/a

Release notes

n/a

Copy link

vercel bot commented Mar 29, 2025

@mootari is attempting to deploy a commit to the tldraw Team on Vercel.

A member of the Team first needs to authorize it.

@huppy-bot huppy-bot bot added the improvement Product improvement label Mar 29, 2025
@mootari
Copy link
Contributor Author

mootari commented Mar 29, 2025

It seems that the run-on sentence immediately after could also use some light restructuring:

will link our image shape to the asset record. Notice that we create the shape with
the same dimensions as the image, later on the user may resize the image, but we
don't want to resize our asset, this is one of the reasons why it's important to
keep assets and shapes separate.

Copy link
Member

@mimecuvalo mimecuvalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ty!
Agreed about the run-on sentence too if you wanna take a stab at that.

@steveruizok
Copy link
Collaborator

Good catch!

@steveruizok steveruizok added this pull request to the merge queue Apr 7, 2025
Merged via the queue into tldraw:main with commit 337f4bc Apr 7, 2025
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Product improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants