Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependencies in release/v1.4 #3493

Open
wants to merge 4 commits into
base: release/v1.4
Choose a base branch
from

Conversation

nddq
Copy link
Contributor

@nddq nddq commented Mar 11, 2025

Reason for Change:

  • Bump all dependencies that have a PR opened by dependabot.
  • Update golangci and crdgen go version

Issue Fixed:

Requirements:

Notes:

@nddq nddq added dependencies Dependencies only. release/1.4 Change affects v1.4 release train labels Mar 11, 2025
@nddq nddq self-assigned this Mar 11, 2025
@Copilot Copilot bot review requested due to automatic review settings March 11, 2025 17:05
@nddq nddq requested review from rbtr, matmerr and vakalapa as code owners March 11, 2025 17:05
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the project’s dependency toolchain to Go 1.24 while refreshing dependency versions managed by Dependabot and updating linting configurations.

  • Update Go versions in GitHub workflow configs
  • Update golangci-lint configuration with modified linter entries

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/crdgen.yaml Update Go versions used for generating CRDs
.github/workflows/golangci.yaml Update Go versions used for linting in workflows
.golangci.yml Add new linters and replace an existing linter entry

@nddq
Copy link
Contributor Author

nddq commented Mar 11, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rbtr
Copy link
Contributor

rbtr commented Mar 11, 2025

I'm not sure what the effect of the go.mod saying 1.23 (toolchain 1.24) and the builder images using MSFT Go 1.23 will be...I think it doesn't actually upgrade us to 1.24

@nddq
Copy link
Contributor Author

nddq commented Mar 11, 2025

I'm not sure what the effect of the go.mod saying 1.23 (toolchain 1.24) and the builder images using MSFT Go 1.23 will be...I think it doesn't actually upgrade us to 1.24

hmm maybe you are right, ill just bump everything to 1.24 then

@nddq nddq requested review from a team as code owners March 11, 2025 19:51
@nddq
Copy link
Contributor Author

nddq commented Mar 11, 2025

linter is not recognizing NPM embedded structs coming from a different module 😕

@nddq
Copy link
Contributor Author

nddq commented Mar 12, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nddq
Copy link
Contributor Author

nddq commented Mar 14, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nddq
Copy link
Contributor Author

nddq commented Mar 21, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nddq
Copy link
Contributor Author

nddq commented Mar 21, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nddq
Copy link
Contributor Author

nddq commented Mar 25, 2025

/azp run Azure Container Networking PR

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Dependencies only. release/1.4 Change affects v1.4 release train
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants