Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pgbouncer user password change should not require verifier #4084

Merged
merged 11 commits into from
Mar 11, 2025

Conversation

philrhurst
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Currently, it is not possible to clear the verifier for the _crunchypgbouncer Secret and only change the password.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

The new behavior mirrors what is possible for the ccp_monitoring user. The verifier can be cleared and the password change. CPK will provide the SCRAM verifier.

Other Information:

@philrhurst philrhurst changed the title regenerate verifier only when user updates pgBouncer Secret password pgbouncer user password change should not require verifier Jan 30, 2025
@andrewlecuyer
Copy link
Collaborator

@philrhurst any thoughts on an integration test to verify this change?

For instance, I do see some existing tests out there to verify the proper contents of the the PgBouncer Secret:

func TestSecret(t *testing.T) {

Maybe this test can be expanded (or a similar test created, etc.) to cover the functionality you've implemented?

@philrhurst
Copy link
Contributor Author

I've added a test. Let me know what you think.

@philrhurst philrhurst merged commit f7b18d4 into CrunchyData:main Mar 11, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants