-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pgbouncer user password change should not require verifier #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@philrhurst any thoughts on an integration test to verify this change? For instance, I do see some existing tests out there to verify the proper contents of the the PgBouncer Secret:
Maybe this test can be expanded (or a similar test created, etc.) to cover the functionality you've implemented? |
I've added a test. Let me know what you think. |
andrewlecuyer
requested changes
Feb 25, 2025
andrewlecuyer
approved these changes
Mar 7, 2025
andrewlecuyer
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
Currently, it is not possible to clear the verifier for the _crunchypgbouncer Secret and only change the password.
What is the new behavior (if this is a feature change)?
The new behavior mirrors what is possible for the ccp_monitoring user. The verifier can be cleared and the password change. CPK will provide the SCRAM verifier.
Other Information: