Calculate Postgres HBA rules in the controller #4111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't use it, and how to quote/escape it has been underspecified for years.
The controller assigned mandatory and default rules but did nothing
with rules defined in the spec.
The patroni.DynamicConfiguration function was interpreting its
schemaless fields while also combining Postgres HBA rules from
elsewhere. Its tests were long and complicated.
1. Postgres HBA rules are now extracted from the schemaless Patroni
field in their own function with its own tests.
2. The PostgresCluster controller now creates a single set of HBA rules
based on all the fields of the PostgresCluster spec.
3. The DynamicConfiguration function is simpler (19 lines, 18% smaller)
and easier to test.
benjaminjb
reviewed
Mar 3, 2025
benjaminjb
reviewed
Mar 3, 2025
| spec: `{ | ||
| patroni: { | ||
| dynamicConfiguration: { | ||
| postgresql: { | ||
| pg_hba: [custom], | ||
| pg_hba: [calculated, elsewhere], |
There was a problem hiding this comment.
These don't come through?
There was a problem hiding this comment.
This function doesn't do that work anymore. Now,
patroni.PostgresHBAsreads them out,postgrescluster.generatePostgresHBAsstitches them together in the right order, then passes that result- here, to
patroni.DynamicConfigurationwhich spells them correctly as input to Patroni.
dsessler7
reviewed
Mar 3, 2025
dsessler7
reviewed
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The controller assigned mandatory and default rules but did nothing with rules defined in the spec.
The
patroni.DynamicConfigurationfunction was interpreting its schemaless fields while also combining Postgres HBA rules from elsewhere. Its tests were long and complicated.Checklist:
Type of Changes: