Clone embedded metrics variable to avoid continuous appending.

[dsessler7]

Checklist:

• Have you added an explanation of what your changes do and why you'd like them to be included?
• Have you updated or added documentation for the change, as applicable?
• Have you tested your changes on all related environments with successful results, as applicable?
  • Have you added automated tests?

Type of Changes:

• New feature
• Bug fix
• Documentation
• Testing enhancement
• Other

What is the current behavior (link to any open issues here)?

Operator always appends to the same global variable, the contents of which are put in a ConfigMap which triggers a reconcile, which forces another appending, etc, etc, until the ConfigMap gets too large.

What is the new behavior (if this is a feature change)?

• Breaking change (fix or feature that would cause existing functionality to change)

The metrics variable in question is cloned so that we no longer continually append to it. ConfigMap doesn't get overloaded.

Other Information:

[benjaminjb]

Nice catch!