Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add replica metric #4130

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Add replica metric #4130

merged 1 commit into from
Mar 11, 2025

Conversation

benjaminjb
Copy link
Contributor

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • New feature
  • Bug fix
  • Documentation
  • Testing enhancement
  • Other

What is the current behavior (link to any open issues here)?

Missing a metric

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

Metric added

Other Information:

benjaminjb
benjaminjb commented Mar 11, 2025
View reviewed changes
internal/collector/postgres_5s_metrics.yaml
metrics:
- metric_name: ccp_is_in_recovery_status
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed this metric for some dashboards.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this one!

@benjaminjb benjaminjb merged commit dbdfc9a into main Mar 11, 2025
19 checks passed
@benjaminjb benjaminjb deleted the benjb/use-ccp-metrics branch March 11, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbandy cbandy

@tony-landreth tony-landreth

@dsessler7 dsessler7

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminjb @cbandy