Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define a struct to share validation rules for PVC specs #4131

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

cbandy
Copy link
Member

@cbandy cbandy commented Mar 11, 2025

This adds some validation to the PGAdmin data volume spec. Tests show we can simplify these validation rules, which may help keep estimated validation costs low.

Checklist:

  • Have you added an explanation of what your changes do and why you'd like them to be included?
  • Have you updated or added documentation for the change, as applicable?
  • Have you tested your changes on all related environments with successful results, as applicable?
    • Have you added automated tests?

Type of Changes:

  • Bug fix

What is the current behavior (link to any open issues here)?

A PGAdmin can be created with an empty/invalid data volume spec, causing errors during reconciliation.

What is the new behavior (if this is a feature change)?

  • Breaking change (fix or feature that would cause existing functionality to change)

The PGAdmin data volume spec shares the same basic validation we do on other volume specs.

This adds some validation to the PGAdmin data volume spec. Tests show
we can simplify these validation rules, which may help keep estimated
validation costs low.
@tjmoore4 tjmoore4 self-requested a review March 11, 2025 15:13
@cbandy cbandy merged commit 39d291d into CrunchyData:main Mar 11, 2025
19 checks passed
@cbandy cbandy deleted the shared-pvc-spec branch March 11, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants