Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service health updates for ga #28326

Merged
merged 2 commits into from
Mar 25, 2025
Merged

Conversation

lee-brian
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

Merge readiness:

  • [ x] Ready for merge

For Datadog employees:
Merge queue is enabled in this repo. Your branch name MUST follow the <name>/<description> convention and include the forward slash (/). Without this format, your pull request will not pass in CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.

If your branch doesn't follow this format, rename it or create a new branch and PR.

To have your PR automatically merged after it receives the required reviews, add the following PR comment:

/merge

Additional notes

@lee-brian lee-brian requested review from a team as code owners March 24, 2025 19:26
Copy link
Contributor

Preview links (active after the build_preview check completes)

Modified Files

@aliciascott
Copy link
Contributor

Hi @lee-brian i see you accidentally committed the go.mod and go.sum files to this branch. Can you remove these from your branch and let us know when it's ready for review? I've added the WIP label for now. Thanks!

Steps:

git checkout master -- go.sum go.mod
git add go.mod
git add go.sum
git commit -m "resetting go files"
git push -u origin <your branch name>

@aliciascott aliciascott added the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 24, 2025
@lee-brian
Copy link
Contributor Author

Whoops sorry about that Alicia - not even sure what I did. That should be fixed, and thanks for providing the git commands!!!

@aliciascott aliciascott removed the WORK IN PROGRESS No review needed, it's a wip ;) label Mar 25, 2025
@maycmlee maycmlee removed the request for review from a team March 25, 2025 20:20
@maycmlee
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2025

View all feedbacks in Devflow UI.
2025-03-25 20:20:42 UTC ℹ️ Start processing command /merge


2025-03-25 20:20:49 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 9m (p90).


2025-03-25 20:24:58 UTC ⚠️ MergeQueue: This merge request build was cancelled

may.lee@datadoghq.com cancelled this merge request build

@maycmlee
Copy link
Contributor

/merge -c

@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2025

View all feedbacks in Devflow UI.
2025-03-25 20:24:51 UTC ℹ️ Start processing command /merge -c

@maycmlee
Copy link
Contributor

Canceling merge because build is broken right now. Will merge once it's been fixed.

@maycmlee
Copy link
Contributor

/merge

@dd-devflow
Copy link

dd-devflow bot commented Mar 25, 2025

View all feedbacks in Devflow UI.
2025-03-25 20:39:05 UTC ℹ️ Start processing command /merge


2025-03-25 20:39:12 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 9m (p90).


2025-03-25 20:47:04 UTC ℹ️ MergeQueue: This merge request was merged

@dd-mergequeue dd-mergequeue bot merged commit 60fd7c6 into master Mar 25, 2025
22 of 30 checks passed
@dd-mergequeue dd-mergequeue bot deleted the brian.lee/service_health_ga branch March 25, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants