Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat single-character capital names as class instead of constant #34

Closed
uranusjr opened this issue Feb 2, 2016 · 2 comments
Closed

Comments

@uranusjr
Copy link

uranusjr commented Feb 2, 2016

Currently, single-character words are highlighted like ALL_CAPS_NAMES, but in practice they are usually class names instead, such as Q and F objects in Django.

It might be better to change the highlighting rule of constants to require at least two characters instead. (Or even two uppercase characters because names like _N also look like a class. This might just be me though.)

@vpetrovykh
Copy link
Member

Yeah, valid point. It really boils down to what is the more common use-case. However, we still plan on trying to make the highlighter more configurable and this may be a good configuration option to add. In the mean time I'll keep this thread open to let anyone else who might have an opinion on the matter chime in.

@1st1
Copy link
Member

1st1 commented Dec 19, 2016

Resolved as part of #42. Closing this issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants