Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi port connection string issue #1222

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

AndrewJackson2020
Copy link
Contributor

@AndrewJackson2020 AndrewJackson2020 commented Feb 5, 2025

Currently when using multiple hosts asyncpg requires there be one port per host. Per the postgres documentation. "As an exception, if only one port is specified, it applies to all the hosts.".

This PR attempts to fix this inconsistency between libpq and asyncpg.

Copy link
Member

@elprans elprans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elprans elprans merged commit 01c0db7 into MagicStack:master Mar 16, 2025
@AndrewJackson2020 AndrewJackson2020 deleted the fix_multi_port_issue branch March 16, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants