Skip to content

Commit 045e7f6

Browse files
committed
tweaks
1 parent e3852eb commit 045e7f6

File tree

2 files changed

+5
-12
lines changed

2 files changed

+5
-12
lines changed

Diff for: biquery_sql_etl/engines/bigquery.py

+3-6
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,8 @@
1+
"""SQL Database Engine."""
2+
13
from sqlalchemy.engine import create_engine
24
from config import (gcp_credentials,
35
bigquery_uri)
46

57

6-
def create_bigquery_engine(uri, creds):
7-
engine = create_engine(uri, credentials_path=creds)
8-
return engine
9-
10-
11-
bigquery_engine = create_bigquery_engine(bigquery_uri, gcp_credentials)
8+
bigquery_engine = create_engine(bigquery_uri, credentials_path=gcp_credentials)

Diff for: biquery_sql_etl/engines/rdbms.py

+2-6
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
"""SQL Database Client."""
1+
"""SQL Database Engine."""
22
from sqlalchemy.engine import create_engine
33
from config import rdbms_uri
44

55

6-
def create_rdbms_engine(uri):
7-
return create_engine(uri)
8-
9-
10-
rdbms_engine = create_rdbms_engine(rdbms_uri)
6+
rdbms_engine = create_engine(rdbms_uri)

0 commit comments

Comments
 (0)