Fix finding the correct cplusplus compiler #23146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExtUtils::CBuilder was using a slightly maverick method for finding the matching cplusplus compiler to the c compiler used to build perl. On a Linux system with a perl built with the Oracle Developer cc cc='/opt/oracle/developerstudio12.6/bin/cc' Errors were observed: "c++: error: unrecognized command line option ‘-KPIC’; did you mean ‘-fPIC’?" The cplusplus command for Oracle Developer suite is CC not c++ and the detection was picking up the system c++ (g++). If there is a ccpath, the code should exhaust all the options and not fail through to using no path.
|
Are there any changes that could be added to CBuilder's test suite that would exercise these code changes? |
haarg
reviewed
Mar 25, 2025
| if( can_run( $cxx1 ) ) { | ||
| $self->{config}{cxx} = $cxx1; | ||
| last; | ||
| } |
There was a problem hiding this comment.
The indentation here doesn't match the rest of the file, and has added literal tabs mixed with the spaces.
There was a problem hiding this comment.
I didn't actually change that from the original, the literal tab was there before. But let me fix that.
|
The test t/03-cpluscplus.t was the test that highlighted to me that the detection behaviour was wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtUtils::CBuilder was using a slightly maverick method for finding the matching cplusplus compiler to the c compiler used to build perl.
On a Linux system with a perl built with the Oracle Developer cc cc='/opt/oracle/developerstudio12.6/bin/cc'
Errors were observed:
"c++: error: unrecognized command line option ‘-KPIC’; did you mean ‘-fPIC’?"
The cplusplus command for Oracle Developer suite is CC not c++ and the detection was picking up the system c++ (g++).
If there is a ccpath, the code should exhaust all the options and not fail through to using no path.
Clang/Clang++ were missing from the C/C++ mappings so I have added those as well.