Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Apollo.io triggers are not logging anything #15841

Closed
andrewjschuang opened this issue Mar 7, 2025 · 7 comments · Fixed by #15991
Closed

[BUG] Apollo.io triggers are not logging anything #15841

andrewjschuang opened this issue Mar 7, 2025 · 7 comments · Fixed by #15991
Assignees
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee

Comments

@andrewjschuang
Copy link
Collaborator

Describe the bug

We need logs to help troubleshoot the trigger. Would be helpful to be able to answer these questions:

  • How many events were fetched in a specific execution?
  • How many were filtered out / emitted?
@andrewjschuang andrewjschuang added the bug Something isn't working label Mar 7, 2025
@vunguyenhung vunguyenhung added the triaged For maintainers: This issue has been triaged by a Pipedream employee label Mar 10, 2025
@jcortes jcortes self-assigned this Mar 18, 2025
@jcortes jcortes moved this from Prioritized to Doing in Component (Source and Action) Backlog Mar 18, 2025
@jcortes
Copy link
Collaborator

jcortes commented Mar 20, 2025

Hi @andrewjschuang I made a few changes in the code as you can see in the PR and in addition to that in order to answer your questions the user can see in the event console the following logs right after running one polling source.

console.log(`Fetched ${resources.length} total resources`);
console.log(`Emitting ${relevantResources.length} resources`);
console.log(`Filtered out ${resources.length - relevantResources.length} unchanged`);

I also made sure the triggers were working as expected with local tests.

@jcortes jcortes moved this from Doing to Ready for PR Review in Component (Source and Action) Backlog Mar 20, 2025
@andrewjschuang
Copy link
Collaborator Author

Cool, thanks @jcortes! I noticed the param debug: true was added to some API requests, is it intentional to keep them there?

@jcortes
Copy link
Collaborator

jcortes commented Mar 20, 2025

@andrewjschuang Oh yes I forgot to mention that I put debug: true so the user can see the requests as well in sources

@andrewjschuang
Copy link
Collaborator Author

@jcortes got it, but are the request / responses being logged? That param is only useful if the user can see the request, but we aren't logging them in the code it seems

@jcortes
Copy link
Collaborator

jcortes commented Mar 20, 2025

@andrewjschuang yes that flag is to log both requests and responses

@andrewjschuang
Copy link
Collaborator Author

@jcortes ah thanks, the lib prints it -- makes sense!

@andrewjschuang andrewjschuang moved this from Ready for PR Review to Ready for QA in Component (Source and Action) Backlog Mar 20, 2025
@vunguyenhung vunguyenhung moved this from Ready for QA to In QA in Component (Source and Action) Backlog Mar 21, 2025
@vunguyenhung vunguyenhung moved this from In QA to Ready for Release in Component (Source and Action) Backlog Mar 21, 2025
@vunguyenhung
Copy link
Collaborator

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/BUG-Apollo-io-triggers-are-not-logging-anything-1bcbf548bb5e819bbb0ac9b5ad0228b0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged For maintainers: This issue has been triaged by a Pipedream employee
Development

Successfully merging a pull request may close this issue.

3 participants