Printful #3739 #4584
Printful #3739 #4584
Conversation
lcaresia
added
action
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
@lcaresia Thanks for your contribution!
I've added a couple of comments below
|
|
||
| export default { | ||
| name: "Create Order", | ||
| version: "0.0.5", |
There was a problem hiding this comment.
Since it's a new action, could you please use the version 0.0.1?
| }, | ||
| items: [ | ||
| { | ||
| id: 286595942, |
There was a problem hiding this comment.
Is this supposed to be hardcoded like that?
| @@ -0,0 +1,20 @@ | |||
| { | |||
| "name": "@pipedream/awork", | |||
| "version": "0.0.2", | |||
There was a problem hiding this comment.
Since it's a new package.json, could you please use the version 0.0.1?
| "main": "awork.app.mjs", | ||
| "keywords": [ | ||
| "pipedream", | ||
| "awork" |
There was a problem hiding this comment.
Please change to: "printful"
| "pipedream", | ||
| "awork" | ||
| ], | ||
| "homepage": "https://pipedream.com/apps/awork", |
There was a problem hiding this comment.
Please change to: "https://pipedream.com/apps/printful"
| ...args, | ||
| }); | ||
| }, | ||
| // async createWebhook({ ...args }) { |
There was a problem hiding this comment.
Please remove this section of commented code.
| type: "action", | ||
| props: { | ||
| printful_oauth, | ||
| externalId: { |
There was a problem hiding this comment.
Since you're using the same props on both components, why not reuse it by importing from a common file?
| name: "New Canceled Order (Instant)", | ||
| version: "0.0.1", | ||
| key: "printful_oauth-new-canceled-order", | ||
| description: "Emit new event on each canceled order.", |
There was a problem hiding this comment.
If possible, please add the docs URL
| name: "New Fulfilled Order (Instant)", | ||
| version: "0.0.1", | ||
| key: "printful_oauth-new-fulfilled-order", | ||
| description: "Emit new event on each fulfilled order.", |
There was a problem hiding this comment.
If possible, please add the docs URL
No description provided.