Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add max31855 sensor #1873

Merged
merged 12 commits into from
Mar 24, 2025
Merged

add max31855 sensor #1873

merged 12 commits into from
Mar 24, 2025

Conversation

wangwang105
Copy link
Contributor

add max31855 sensor

@wangwang105 wangwang105 mentioned this pull request Mar 18, 2025
Open
supperthomas
supperthomas requested changes Mar 19, 2025
View reviewed changes
peripherals/sensors/max31855/package.json Outdated
"site": [
{
"version": "v1.0.0",
"URL": "https://github.com/wangwang105/rtt-max31855/releases/tag/v1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个url参考其他软件包，应该是zip结尾

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

谢谢~~ 我改一下~

@supperthomas
Copy link
Member

标题改一下

@wangwang105 wangwang105 changed the title Develop add max31855 sensor Mar 20, 2025
@supperthomas
Copy link
Member

https://github.com/wangwang105/rtt-max31855/archive/refs/tags/v1.0.0.zip

@supperthomas
Copy link
Member

image

这个填的地址，自己可以在浏览器里面试下，是否可以下下来。

@wangwang105
Copy link
Contributor Author

image

这个填的地址，自己可以在浏览器里面试下，是否可以下下来。

我改了，应该是可以了，谢了

@supperthomas
Copy link
Member 

/home/runner/work/packages/packages/packages_temp/packages/peripherals/sensors/max31855/package.json
package name:mx31855
package folder name: max31855

是叫mx31855还是叫max31855？ 全局替换一下。

@wangwang105
Copy link
Contributor Author 

/home/runner/work/packages/packages/packages_temp/packages/peripherals/sensors/max31855/package.json
package name:mx31855
package folder name: max31855

是叫mx31855还是叫max31855？ 全局替换一下。

好的好的，我太粗心了

@supperthomas supperthomas merged commit b3e81cd into RT-Thread:master Mar 24, 2025
11 of 12 checks passed
@supperthomas
Copy link
Member

感谢PR

@supperthomas
Copy link
Member

image
下次可以自行检查一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@supperthomas supperthomas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangwang105 @supperthomas