Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity/Block Persistence + Entity Despawnable #7564

Merged

Conversation

Absolutionism
Copy link
Contributor

@Absolutionism Absolutionism commented Feb 1, 2025

Description

This PR aims to add the ability of changing the persistence of entities and blocks (leaves) and change if an entity should despawn when far away.

No test for EntityUnload because it requires a tick.
Yes, I did try the JUnit thing, but was not viable as sometimes it succeeded and other times failed.
Granted if I did it correctly, look at the Initial Commit


Target Minecraft Versions: any
Requirements: none
Related Issues: #7154

Copy link
Member

@Efnilite Efnilite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your junit attempt did not call the actual event with java code, which is why it didnt work

@sovdeeth sovdeeth added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Feb 2, 2025
@sovdeeth sovdeeth added the feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. label Feb 22, 2025
@Fusezion
Copy link
Contributor

While looking through issues found #6794 which this completes

@Absolutionism Absolutionism requested a review from a team as a code owner March 19, 2025 22:33
@Absolutionism Absolutionism requested review from erenkarakal and UnderscoreTud and removed request for ShaneBeee March 19, 2025 22:33
@Efnilite Efnilite merged commit c0f6ba4 into SkriptLang:dev/feature Mar 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request, an issue about something that could be improved, or a PR improving something. feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants