-
-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entity/Block Persistence + Entity Despawnable #7564
Merged
Efnilite
merged 9 commits into
SkriptLang:dev/feature
from
Absolutionism:dev/Persistence+Despawnable
Mar 20, 2025
Merged
Entity/Block Persistence + Entity Despawnable #7564
Efnilite
merged 9 commits into
SkriptLang:dev/feature
from
Absolutionism:dev/Persistence+Despawnable
Mar 20, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Efnilite
requested changes
Feb 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
your junit attempt did not call the actual event with java code, which is why it didnt work
ShaneBeee
suggested changes
Feb 1, 2025
sovdeeth
requested changes
Feb 2, 2025
sovdeeth
requested changes
Feb 5, 2025
Efnilite
approved these changes
Feb 12, 2025
sovdeeth
approved these changes
Feb 16, 2025
While looking through issues found #6794 which this completes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
feature-ready
A PR/issue that has been approved, tested and can be merged/closed in the next feature version.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add the ability of changing the persistence of entities and blocks (leaves) and change if an entity should despawn when far away.
No test for
EntityUnload
because it requires a tick.Yes, I did try the JUnit thing, but was not viable as sometimes it succeeded and other times failed.
Granted if I did it correctly, look at the
Initial Commit
Target Minecraft Versions: any
Requirements: none
Related Issues: #7154