Fix TropicalFishData spawning incorrect type #7744
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fusezion
requested review from
cheeezburga and
erenkarakal
and removed request for
a team
Efnilite
approved these changes
Mar 24, 2025
Efnilite
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to fix an issue with the TropticalFIsh entity data always spawning the next fish in enum ordinal instead of the expected type.
I.e. Snooper always was Dasher, Spotty was always Flopper, ect...
The fix for this was to not do
+ 1for ordinals and move "tropical fish" to the end of the code names listTarget Minecraft Versions: any
Requirements: none
Related Issues: none
Before
After
and just to show random still works when undefined
