Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove senseless dynamic config to simplify code base #131

Merged
merged 2 commits into from
Aug 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -40,12 +40,12 @@ jobs:
- name: Install cmake dependencies and run cmake compile
run: |
sudo apt update
sudo apt -y install cmake
sudo apt -y install cmake
sudo git clone -b v9.1.0 https://github.com/apache/skywalking-data-collect-protocol.git ./3rdparty/skywalking-data-collect-protocol
sudo git clone -b v1.46.6 https://github.com/grpc/grpc.git --recursive
sudo cmake -S ./grpc -B ./grpc/build
sudo cmake -S ./grpc -B ./grpc/build
sudo cmake --build ./grpc/build --parallel 8 --target install
sudo cmake -S . -B ./build
sudo cmake -S . -B ./build
sudo cmake --build ./build
- name: Install lcov and genhtml and link llvm
run: |
@@ -70,7 +70,7 @@ jobs:
- uses: actions/checkout@v3
- name: Prepare service container
run: |
docker-compose -f test/e2e/docker/docker-compose.e2e.yml up -d
docker compose -f test/e2e/docker/docker-compose.e2e.yml up -d
- name: Run e2e
run: |
pip3 install --upgrade pip
@@ -84,7 +84,7 @@ jobs:
- uses: actions/checkout@v3
- name: Prepare service container
run: |
docker-compose -f test/e2e/docker/docker-compose.e2e-python.yml up -d
docker compose -f test/e2e/docker/docker-compose.e2e-python.yml up -d
- name: Run e2e
run: |
pip3 install --upgrade pip
4 changes: 0 additions & 4 deletions source/BUILD
Original file line number Diff line number Diff line change
@@ -3,16 +3,12 @@ load("@rules_cc//cc:defs.bzl", "cc_library")
cc_library(
name = "cpp2sky_lib",
srcs = [
"cds_impl.cc",
"dynamic_config.cc",
"grpc_async_client_impl.cc",
"propagation_impl.cc",
"tracer_impl.cc",
"tracing_context_impl.cc",
],
hdrs = [
"cds_impl.h",
"dynamic_config.h",
"grpc_async_client_impl.h",
"propagation_impl.h",
"tracer_impl.h",
86 changes: 0 additions & 86 deletions source/cds_impl.cc

This file was deleted.

103 changes: 0 additions & 103 deletions source/cds_impl.h

This file was deleted.

93 changes: 0 additions & 93 deletions source/dynamic_config.cc

This file was deleted.

45 changes: 0 additions & 45 deletions source/dynamic_config.h

This file was deleted.

Loading
Oops, something went wrong.
Loading
Oops, something went wrong.