Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular-query): forward queryFn errors to the NgZone #8842

Merged
merged 3 commits into from
Mar 22, 2025
Merged

fix(angular-query): forward queryFn errors to the NgZone #8842

merged 3 commits into from
Mar 22, 2025
+2 −0

Conversation

JoepKockelkorn
Copy link
Contributor

@JoepKockelkorn JoepKockelkorn commented Mar 21, 2025 •
edited
Loading

Any errors that occur in the queryFn or mutationnFn that should be thrown in case of throwOnError: true should run in the NgZone, or else the Angular ErrorHandler will not pick them up. A manual try...catch is needed because any errors that occur inside of ngZone.run are not automatically reported in the zone:

If a synchronous error happens it will be rethrown and not reported via onError.

This fixes #8839.

@JoepKockelkorn
Copy link
Contributor Author

Not sure if the extra wrapping try...catch is needed 🤔

@JoepKockelkorn
Copy link
Contributor Author

Removed the try...catch wrappers as they were indeed redundant.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 066cb8f.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-22 00:11:58 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 22, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8842

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8842

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8842

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8842

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8842

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8842

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8842

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8842

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8842

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8842

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8842

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8842

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8842

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8842

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8842

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8842

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8842

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8842

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8842

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8842

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8842

commit: 066cb8f

@codecov Codecov
Copy link

codecov bot commented Mar 22, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.08%. Comparing base (a9b073a) to head (066cb8f).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8842       +/-   ##
===========================================
+ Coverage   46.60%   88.08%   +41.47%     
===========================================
  Files         200       16      -184     
  Lines        7574      277     -7297     
  Branches     1741       44     -1697     
===========================================
- Hits         3530      244     -3286     
+ Misses       3668       32     -3636     
+ Partials      376        1      -375
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.08% <50.00%> (-0.28%) ⬇️
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arnoud-dv arnoud-dv merged commit e540484 into TanStack:main Mar 22, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Angular: caught errors in the queryFn do not run in the zone
2 participants
@JoepKockelkorn @arnoud-dv