Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler warning/note in type-builder.cpp #7383

Closed
sbc100 opened this issue Mar 20, 2025 · 0 comments · Fixed by #7395
Closed

Compiler warning/note in type-builder.cpp #7383

sbc100 opened this issue Mar 20, 2025 · 0 comments · Fixed by #7395
Assignees

Comments

@sbc100
Copy link
Member

sbc100 commented Mar 20, 2025

With the compiler on my cloudtop I'm seeing this note/warning:

ninja: Entering directory `../binaryen-out/'
[223/224] Building CXX object test/gtest/CMakeFiles/binaryen-unittests.dir/type-builder.cpp.o
In file included from /usr/local/google/home/sbc/dev/wasm/binaryen/third_party/googletest/googletest/include/gtest/gtest.h:62,
                 from /usr/local/google/home/sbc/dev/wasm/binaryen/test/gtest/type-test.h:2,
                 from /usr/local/google/home/sbc/dev/wasm/binaryen/test/gtest/type-builder.cpp:2:
/usr/local/google/home/sbc/dev/wasm/binaryen/test/gtest/type-builder.cpp: In member function ‘virtual void TypeTest_TestTypeRelations_Test::TestBody()’:
/usr/local/google/home/sbc/dev/wasm/binaryen/test/gtest/type-builder.cpp:1175:8: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
 1175 | TEST_F(TypeTest, TestTypeRelations) {
      |        ^~~~~~~~
@tlively tlively self-assigned this Mar 20, 2025
tlively added a commit that referenced this issue Mar 25, 2025
The length macro used in a type test in type-builder.cpp was causing
extremely long compile times in some compilers. Use a lambda instead to
fix it. This makes the error messages less useful when a test fails, but
under normal circumstances the test should not be failing, so this is a
good trade off.

Fixes #7383.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants