Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[19.2.x]: Fourth iteration of ts_library migration #30714

Merged
merged 6 commits into from
Mar 26, 2025

Conversation

devversion
Copy link
Member

Patch port of #30710 and #30704

The `ts_project` interop currently conflicts with some mappings from
e.g. `ts_library`. This can happen when the same target is transitively
referenced via the interop, or directly in e.g. `ng_module` still.
Migrates all `ng_test_library` targets to `ts_project`.
The new version contains some changes to support `--traceResolution`,
which is useful for debugging.
The `rules_js` `npm_package` rule does not support nested NPM packages,
so we should stop doing that and instead use an idiomatic filegroup.
Migrates all `ng_e2e_test_library` targets to use `ts_project` directly.
This is simpler and more obvious.
This rule is no longer needed, so we can remove it from our macros.

Also removes patches for it.
@devversion devversion changed the base branch from main to 19.2.x March 26, 2025 09:49
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 26, 2025
@devversion devversion closed this Mar 26, 2025
@devversion devversion reopened this Mar 26, 2025
@devversion devversion requested a review from crisbeto March 26, 2025 10:37
@devversion devversion marked this pull request as ready for review March 26, 2025 10:37
@devversion devversion requested review from a team as code owners March 26, 2025 10:37
@devversion devversion requested review from mmalerba and removed request for a team March 26, 2025 10:37
@devversion devversion added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Mar 26, 2025
@devversion devversion merged commit a46e263 into angular:19.2.x Mar 26, 2025
29 of 30 checks passed
@devversion devversion deleted the rjs-5-patch branch March 26, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants