undo removal of accessLogger and deal with some warnings

[DaanHoogland]

Description

This PR

Fixes: #10565

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

Attention: Patch coverage is 27.41935% with 45 lines in your changes missing coverage. Please review.

Project coverage is 16.00%. Comparing base (f8adedc) to head (d54978e).
Report is 6 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
server/src/main/java/com/cloud/api/ApiServer.java	27.41%	45 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10567   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
- Complexity    13104    13105    +1     
=========================================
  Files          5651     5651           
  Lines        495843   495866   +23     
  Branches      60045    60048    +3     
=========================================
+ Hits          79363    79372    +9     
- Misses       407624   407631    +7     
- Partials       8856     8863    +7     

Flag	Coverage Δ
uitests	4.00% <ø> (ø)
unittests	16.84% <27.41%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[GutoVeronezi]

CLGTM

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12788

[Pearl1594]

@blueorangutan test

[blueorangutan]

@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[gpordeus]

I'd probably call the logger ACCESS_LOGGER (or API_LOGGER) since it's a constant, but it's not really an issue. LGTM

Edit: Actually, nevermind since it's a reference.

[Pearl1594]

Thanks for reviewing @gpordeus!

[blueorangutan]

[SF] Trillian test result (tid-12728)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60369 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10567-t12728-kvm-ol8.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestIpv4Routing>:setup	Error	0.00	test_ipv4_routing.py
test_04_list_domains_level_filter	Failure	0.05	test_list_domains.py
test_05_list_domains_no_filter	Failure	0.04	test_list_domains.py
ContextSuite context=TestSharedNetworkWithConfigDrive>:setup	Error	1520.66	test_network.py
test_01_sys_vm_start	Failure	0.13	test_secondary_storage.py

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 12831

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12850

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12808)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 70993 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10567-t12808-kvm-ol8.zip
Smoke tests completed. 134 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestPrivateGwACL>:setup	Error	0.00	test_privategw_acl.py
test_01_create_template	Error	1.16	test_templates.py
test_CreateTemplateWithDuplicateName	Error	1.13	test_templates.py
test_02_create_template_with_checksum_sha1	Error	65.62	test_templates.py
test_03_create_template_with_checksum_sha256	Error	65.61	test_templates.py
test_04_create_template_with_checksum_md5	Error	65.64	test_templates.py
test_05_create_template_with_no_checksum	Error	65.60	test_templates.py
ContextSuite context=TestTemplates>:setup	Error	273.70	test_templates.py
ContextSuite context=TestISOUsage>:setup	Error	0.00	test_usage.py
test_01_snapshot_usage	Error	27.80	test_usage.py
test_01_template_usage	Error	1.23	test_usage.py
test_06_download_detached_volume	Error	303.09	test_volumes.py
test_13_migrate_volume_and_change_offering	Error	129.16	test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup	Error	0.00	test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup	Error	0.00	test_vpc_redundant.py
test_01_redundant_vpc_site2site_vpn	Failure	481.40	test_vpc_vpn.py

[Pearl1594]

Waiting for test run - initiated directly on Jenkins