Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Restore AS Numbers and IPv4 Subnets menus #10580

Open
wants to merge 3 commits into
base: 4.20
Choose a base branch
from

Conversation

nvazquez
Copy link
Contributor

@nvazquez nvazquez commented Mar 17, 2025

Description

This PR fixes a regression on the UI in which the AS Numbers menu tab was removed, caused by the merge commit: 34d2a3b (check network.js file diff)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before:
Screenshot 2025-03-17 at 12 32 22

After:
Screenshot 2025-03-17 at 12 49 25

How did you try to break this feature and the system with this change?

@nvazquez nvazquez force-pushed the ui-fix-as-numbers branch from 4d2b0c2 to 84a2b04 Compare March 17, 2025 15:40
@nvazquez nvazquez changed the base branch from main to 4.20 March 17, 2025 15:41
@nvazquez nvazquez changed the title UI: Restore AS Numbers menu UI: Restore AS Numbers and IPv4 Subnets menus Mar 17, 2025
@nvazquez
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.00%. Comparing base (f8adedc) to head (6792319).
Report is 4 commits behind head on 4.20.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.20   #10580   +/-   ##
=========================================
  Coverage     16.00%   16.00%           
- Complexity    13104    13105    +1     
=========================================
  Files          5651     5651           
  Lines        495843   495878   +35     
  Branches      60045    60048    +3     
=========================================
+ Hits          79363    79369    +6     
- Misses       407624   407646   +22     
- Partials       8856     8863    +7     
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 16.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

image

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10580 (QA-JID-577)

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vishesh92
Copy link
Member

I think we need to add some more changes back from the 34d2a3b. Specifically around guest network's details, bgp.peer, rotuing.firewall tab, etc.

@nvazquez
Copy link
Contributor Author

Thanks @vishesh92 I have addressed that on the last commit, can you please re-review?

@nvazquez
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10580 (QA-JID-578)

@rohityadavcloud rohityadavcloud added this to the 4.20.1 milestone Mar 18, 2025
@Pearl1594
Copy link
Contributor

@vishesh92 is your concern addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants