-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Restore AS Numbers and IPv4 Subnets menus #10580
base: 4.20
Are you sure you want to change the base?
Conversation
4d2b0c2
to
84a2b04
Compare
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10580 +/- ##
=========================================
Coverage 16.00% 16.00%
- Complexity 13104 13105 +1
=========================================
Files 5651 5651
Lines 495843 495878 +35
Branches 60045 60048 +3
=========================================
+ Hits 79363 79369 +6
- Misses 407624 407646 +22
- Partials 8856 8863 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I think we need to add some more changes back from the 34d2a3b. Specifically around guest network's details, bgp.peer, rotuing.firewall tab, etc. |
Thanks @vishesh92 I have addressed that on the last commit, can you please re-review? |
@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@vishesh92 is your concern addressed? |
Description
This PR fixes a regression on the UI in which the AS Numbers menu tab was removed, caused by the merge commit: 34d2a3b (check network.js file diff)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Before:

After:

How did you try to break this feature and the system with this change?