Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host status auto refresh #10606

Merged
merged 3 commits into from
Mar 25, 2025
Merged

Conversation

Imvedansh
Copy link
Contributor

Description

This PR... fixes #10604 When a user disables/Enables a host from the Infrastructure - Host tab (List view), the UI does not refresh automatically to reflect the new disabled state of the host. The API call succeeds, but the user doesn't see the state change until they manually refresh the page.

#10604

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screen.Recording.2025-03-21.at.11.18.17.PM.mov

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@bernardodemarco
Copy link
Collaborator

@blueorangutan ui

@blueorangutan
Copy link

@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-580)

@Imvedansh Imvedansh changed the base branch from main to 4.19 March 23, 2025 00:37
@Imvedansh Imvedansh changed the base branch from 4.19 to 4.19-merge March 23, 2025 00:42
@Imvedansh Imvedansh changed the base branch from 4.19-merge to 4.20 March 23, 2025 00:45
@Imvedansh Imvedansh changed the base branch from 4.20 to 4.19 March 23, 2025 00:46
@Imvedansh Imvedansh changed the base branch from 4.19 to main March 23, 2025 00:49
@DaanHoogland
Copy link
Contributor

@Imvedansh , it seems to me you would like this into version 4.20?! You have submitted a change to main (meaning 21). You might want to rebase your changes onto the release branch 4.20.

git rebase --onto 4.20 <commit before your changes> <your latest commit>

Copy link

codecov bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.89%. Comparing base (c9c02d0) to head (d82fdbb).
Report is 1 commits behind head on 4.19.

Additional details and impacted files
@@             Coverage Diff              @@
##               4.19   #10606      +/-   ##
============================================
+ Coverage     15.16%   15.89%   +0.72%     
  Complexity    11330    11330              
============================================
  Files          5414     5046     -368     
  Lines        474811   445155   -29656     
  Branches      57910    52704    -5206     
============================================
- Hits          72021    70749    -1272     
+ Misses       394737   366498   -28239     
+ Partials       8053     7908     -145     
Flag Coverage Δ
uitests ?
unittests 15.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Imvedansh Imvedansh changed the base branch from main to 4.19 March 24, 2025 12:14
@Imvedansh Imvedansh force-pushed the Host-status-auto-refresh branch from a85e312 to 06ddb1a Compare March 24, 2025 12:21
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@Imvedansh
Copy link
Contributor Author

@DaanHoogland Yes, you are absolutely right! I have rebased onto 4.19, ensuring that the feature can be included in next month's update, will keep you posted!
Thank you much

@DaanHoogland DaanHoogland added this to the 4.19.3 milestone Mar 24, 2025
@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-584)

@@ -5,12 +5,14 @@ All notable changes to Linstor CloudStack plugin will be documented in this file
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).


Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe these changes on plugins/storage/volume/linstor/CHANGELOG.md are not necessary, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice cleanup though, aren't they?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure , I agree

Comment on lines +132 to +145
width: 30vw;
@media (min-width: 500px) {
width: 450px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes necessary?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just reformat. these are fine aren't they?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, not often will make a difference, will remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me just push the feature in first go , and will do the enhancement later on

@Imvedansh
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@Imvedansh Imvedansh force-pushed the Host-status-auto-refresh branch from 57128dc to e920123 Compare March 24, 2025 17:24
@Imvedansh Imvedansh force-pushed the Host-status-auto-refresh branch from e920123 to 2392d71 Compare March 24, 2025 17:25
@Imvedansh Imvedansh marked this pull request as draft March 24, 2025 17:30
@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-585)

@Imvedansh
Copy link
Contributor Author

@blueorangutan ui

@blueorangutan
Copy link

@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10606 (QA-JID-586)

@Imvedansh Imvedansh marked this pull request as ready for review March 24, 2025 18:31
Copy link
Collaborator

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, tested in the QA environment

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
6 participants