-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host status auto refresh #10606
Host status auto refresh #10606
Conversation
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@Imvedansh , it seems to me you would like this into version 4.20?! You have submitted a change to main (meaning 21). You might want to rebase your changes onto the release branch 4.20.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10606 +/- ##
============================================
+ Coverage 15.16% 15.89% +0.72%
Complexity 11330 11330
============================================
Files 5414 5046 -368
Lines 474811 445155 -29656
Branches 57910 52704 -5206
============================================
- Hits 72021 70749 -1272
+ Misses 394737 366498 -28239
+ Partials 8053 7908 -145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a85e312
to
06ddb1a
Compare
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
@DaanHoogland Yes, you are absolutely right! I have rebased onto 4.19, ensuring that the feature can be included in next month's update, will keep you posted! |
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
@@ -5,12 +5,14 @@ All notable changes to Linstor CloudStack plugin will be documented in this file | |||
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), | |||
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these changes on plugins/storage/volume/linstor/CHANGELOG.md
are not necessary, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup though, aren't they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure , I agree
width: 30vw; | ||
@media (min-width: 500px) { | ||
width: 450px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just reformat. these are fine aren't they?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, not often will make a difference, will remove it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me just push the feature in first go , and will do the enhancement later on
@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
57128dc
to
e920123
Compare
e920123
to
2392d71
Compare
UI build: ✔️ |
@Imvedansh a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
UI build: ✔️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested in the QA environment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
This PR... fixes #10604 When a user disables/Enables a host from the Infrastructure - Host tab (List view), the UI does not refresh automatically to reflect the new disabled state of the host. The API call succeeds, but the user doesn't see the state change until they manually refresh the page.
#10604Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Screen.Recording.2025-03-21.at.11.18.17.PM.mov
How Has This Been Tested?
How did you try to break this feature and the system with this change?