Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Add 4.0.0 to core system tests #19238

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

dajac
Copy link
Member

@dajac dajac commented Mar 19, 2025

This patch updates all the core system tests to include 4.0.0.

Reviewers: Andrew Schofield aschofield@confluent.io, Lianet Magrans lmagrans@confluent.io

@github-actions github-actions bot added tests Test fixes (including flaky tests) small Small PRs labels Mar 19, 2025
@dajac
Copy link
Member Author

dajac commented Mar 19, 2025

I have triggered a run of the system tests. I will post the results when they are done.

@dajac
Copy link
Member Author

dajac commented Mar 20, 2025

Here is the result of all the system tests: https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/trunk/2025-03-19--001.525166ce-17a5-49d0-a2c3-972af99ef7ca--1742409351--dajac--minor-update-core-systest-4.0--abd771e77f/report.html.

There are some failures, mainly about the share consumer, but they are not related to the changes made in this PR.

Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you did not include the transactions_mixed_versions_test.py and transactions_upgrade_test.py? Apart from those, this looks to me.

@dajac
Copy link
Member Author

dajac commented Mar 20, 2025

Any reason why you did not include the transactions_mixed_versions_test.py and transactions_upgrade_test.py? Apart from those, this looks to me.

Oops. I missed those two. Let me update them too.

@lianetm
Copy link
Member

lianetm commented Mar 20, 2025

Similar, should we include streams_broker_compatibility_test.py and streams_application_upgrade_test.py?

@dajac
Copy link
Member Author

dajac commented Mar 20, 2025

Similar, should we include streams_broker_compatibility_test.py and streams_application_upgrade_test.py?

They are handled separately: #19239

Copy link
Member

@lianetm lianetm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM then, thanks! (let's just check the results of a run with the update)

@dajac
Copy link
Member Author

dajac commented Mar 20, 2025

I ran transactions_mixed_versions_test.py and transactions_upgrade_test.py locally and they both passed.

@dajac dajac merged commit 573b31d into apache:trunk Mar 20, 2025
24 checks passed
@dajac dajac deleted the minor-update-core-systest-4.0 branch March 20, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants