Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] don't write to disk cache #4032

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Conversation

codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Mar 19, 2025

Description of changes

Our usage of foyer (manually inserting to disk and memory cache at the same time) seems to uncover bugs in foyer, so we're going to instead follow the happy path of foyer and only insert to the in-memory cache for now (and deal with worse cache perf across rollouts).

Made a new issue tracking the bug: #4040.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs repository?

n/a

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link

Please tag your PR title with one of: [ENH | BUG | DOC | TST | BLD | PERF | TYP | CLN | CHORE]. See https://docs.trychroma.com/contributing#contributing-code-and-ideas

Copy link
Contributor Author

codetheweb commented Mar 19, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codetheweb codetheweb changed the title Don't write to disk cache [BUG] don't write to disk cache Mar 19, 2025
@codetheweb codetheweb force-pushed the fix-foyer-remove-disk-cache-insert branch 2 times, most recently from 9704dba to 4d601a5 Compare March 19, 2025 18:54
@codetheweb codetheweb mentioned this pull request Mar 19, 2025
1 task
@codetheweb codetheweb force-pushed the tst-enable-normal-proptest-preset-in-prs branch from 5ed1b68 to 96243fd Compare March 20, 2025 02:59
@codetheweb codetheweb force-pushed the fix-foyer-remove-disk-cache-insert branch from 4d601a5 to f3afc69 Compare March 20, 2025 02:59
@codetheweb codetheweb marked this pull request as ready for review March 20, 2025 16:39
@codetheweb codetheweb requested a review from sanketkedia March 20, 2025 16:39
@codetheweb codetheweb force-pushed the fix-foyer-remove-disk-cache-insert branch from f3afc69 to c05d16f Compare March 21, 2025 18:33
@codetheweb codetheweb changed the base branch from tst-enable-normal-proptest-preset-in-prs to main March 21, 2025 18:33
@codetheweb codetheweb force-pushed the fix-foyer-remove-disk-cache-insert branch from c05d16f to 506fc45 Compare March 21, 2025 19:17
@codetheweb codetheweb merged commit 4bfa497 into main Mar 21, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants