Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skeleton validation error should have required property id #111

Closed
jcandan opened this issue Jan 26, 2025 · 2 comments
Closed

Fix skeleton validation error should have required property id #111

jcandan opened this issue Jan 26, 2025 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@jcandan
Copy link

jcandan commented Jan 26, 2025

Describe the bug

Running coderoad build gives a skeleton validation error: should have required property 'id', even after a coderoad validate success.

$ coderoad validate
...
--- Running setup test...
--- Loading solution commits...
--- Running solution test...

✔ Success!
$ coderoad build
Building CodeRoad tutorial.json...
Validation error at  - should have required property 'id'
Skeleton validation failed. See above to see what to fix

To Reproduce

I was getting this having completed the tutorial up to Build the config.json file.

I was able to reproduce this with one of the available example projects.

Note: I did need to capture all the branches, and I provide a loop to do that.

git clone git@github.com:coderoad/fcc-learn-npm.git
cd fcc-learn-npm/
for remote in `git branch -r`; do git branch --track ${remote#origin/} $remote; done
coderoad validate
coderoad build

Expected behavior

A successful build.

Desktop (please complete the following information):

  • Platfrom: Windows 11 Version 23H2 (OS Build 22631.2861)
  • OS: Ubuntu via WSL2
  • Version 24.04.1

Node (please complete the following information):

  • Version v20.18.2

Git (please complete the following information):

  • Version 2.43.0

Additional context

N/A

@jcandan jcandan added the bug Something isn't working label Jan 26, 2025
@jcandan
Copy link
Author

jcandan commented Jan 26, 2025

Additionally confirmed this issue with Node v18.20.6.

@jcandan
Copy link
Author

jcandan commented Jan 27, 2025

I found the solution.

Reading through the skeleton schema, I found the following:

    id: {
      type: "string",
      description: "A unique identifier for your tutorial. Currently no system to create this, so create your own for now",
      examples: ["fcc-learn-npm"]
    },

When I added id: 'fcc-learn-npm, it allowed the coderoad build to succeed.

I'll create an issue to address this in the examples and tutorial.

@jcandan jcandan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants