Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github-actions): add "3.13-dev" to Python tests (#1145) #1170

Merged
merged 4 commits into from
Aug 11, 2024
Merged

ci(github-actions): add "3.13-dev" to Python tests (#1145) #1170

merged 4 commits into from
Aug 11, 2024

Conversation

jakob-keller
Copy link
Contributor

@jakob-keller jakob-keller commented Jun 26, 2024

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

GitHub Actions will run tests for Python 3.13 (dev).

Steps to Test This Pull Request

Additional context

closes #1145

Sorry, something went wrong.

@jakob-keller
Copy link
Contributor Author

Looks like there are currently incompatibilities with cffi under Python 3.13: python-cffi/cffi#77 We will need to await their next release which is imminent.

@Lee-W
Copy link
Member

Lee-W commented Jul 26, 2024

looks like they've got it resolved. but rebasing doesn't seem to work still

@jakob-keller
Copy link
Contributor Author

looks like they've got it resolved. but rebasing doesn't seem to work still

Apparently it was fixed, but the release is still pending.

@jakob-keller jakob-keller changed the title ci(github-actions): add "3.13-dev" to Python tests (#1145) ci(github-actions): add "3.13" to Python tests (#1145) Jul 26, 2024
@jakob-keller jakob-keller changed the title ci(github-actions): add "3.13" to Python tests (#1145) ci(github-actions): add "3.13-dev" to Python tests (#1145) Jul 26, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.56%. Comparing base (120d514) to head (82c0459).
Report is 395 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1170      +/-   ##
==========================================
+ Coverage   97.33%   97.56%   +0.22%     
==========================================
  Files          42       55      +13     
  Lines        2104     2502     +398     
==========================================
+ Hits         2048     2441     +393     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.56% <ø> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakob-keller
Copy link
Contributor Author

jakob-keller commented Aug 8, 2024

cffi==1.17.0 has been released, which helps a lot.

Now it turns out that Python 3.13 modifies the behaviour of argparse --help: python/cpython#103372. I have updated relevant tests accordingly. Please let me know, if we need to keep the tests for Python 3.12 and earlier.

There is also a single failing test caused by the removal of pipes in Python 3.13: https://github.com/pre-commit/mirrors-prettier is no longer maintained, but used in test_bump_pre_commit_changelog. I have marked that test as skip for the time being. IMO, the test should be modified to avoid mirrors-prettier, independent of Python 3.13 support.

…irrors-prettier`
@jakob-keller jakob-keller marked this pull request as ready for review August 8, 2024 22:36
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit hesitant about whether we should use version 3.13 or below. However, since this is not a critical test, I think we should be fine.

@Lee-W
Copy link
Member

Lee-W commented Aug 9, 2024

I'll keep it open for a few days. cc @woile @noirbizarre

@Lee-W Lee-W added pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check and removed pr-status: wait-for-review labels Aug 9, 2024
@Lee-W Lee-W merged commit 01fd042 into commitizen-tools:master Aug 11, 2024
21 checks passed
@jakob-keller jakob-keller deleted the python-3.13-ci branch August 11, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: ready-to-merge almost ready to merge. just keep it for a few days for others to check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add python3.13 beta to github actions for testing
2 participants