Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CIcon): fix class order and incorrect class name, update docs #300

Closed
wants to merge 1 commit into from
Closed

fix(CIcon): fix class order and incorrect class name, update docs #300

wants to merge 1 commit into from

Conversation

klaseca
Copy link

@klaseca klaseca commented Jul 7, 2022

This pull request include:

Fixed incorrect class order

Now if we pass a size property with a value of custom-size, we do not get expected class (icon-custom-size), because it is further excluded by other conditions (lack of width or height)

Fixed incorrect class name

Class icon-c-s is currently used, although it should be used icon-custom (according to declared types)

Updated docs

Added instructions for using css

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant